Skip to content

Commit 1243b74

Browse files
FdawgsFdawgs
authored
perf: use node: prefix to bypass require.cache call for builtins (#477)
* perf: use `node:` prefix to bypass require.cache call for builtins See fastify/fastify-static#407 * docs: use `node:` prefix to bypass require.cache call for builtins
1 parent 2c633c3 commit 1243b74

26 files changed

+89
-89
lines changed

‎README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ If you are looking for the documentation for the legacy callback-api please see
2626

2727
```js
2828
const fastify = require('fastify')()
29-
const fs = require('fs')
30-
const util = require('util')
31-
const { pipeline } = require('stream')
29+
const fs = require('node:fs')
30+
const util = require('node:util')
31+
const { pipeline } = require('node:stream')
3232
const pump = util.promisify(pipeline)
3333

3434
fastify.register(require('@fastify/multipart'))

‎callback.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
```js
1212
const fastify = require('fastify')()
1313
const concat = require('concat-stream')
14-
const fs = require('fs')
14+
const fs = require('node:fs')
1515
const pump = require('pump')
1616

1717
fastify.register(require('@fastify/multipart'))

‎examples/example-legacy.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
'use strict'
22

33
const fastify = require('fastify')()
4-
const fs = require('fs')
5-
const path = require('path')
4+
const fs = require('node:fs')
5+
const path = require('node:path')
66
const pump = require('pump')
77
const form = path.join(__dirname, '..', 'form.html')
88

‎examples/example.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
'use strict'
22

33
const fastify = require('fastify')()
4-
const fs = require('fs')
5-
const util = require('util')
6-
const path = require('path')
7-
const { pipeline } = require('stream')
4+
const fs = require('node:fs')
5+
const util = require('node:util')
6+
const path = require('node:path')
7+
const { pipeline } = require('node:stream')
88
const pump = util.promisify(pipeline)
99
const form = path.join(__dirname, '..', 'form.html')
1010

‎index.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
'use strict'
22

33
const Busboy = require('@fastify/busboy')
4-
const os = require('os')
4+
const os = require('node:os')
55
const fp = require('fastify-plugin')
66
const eos = require('end-of-stream')
7-
const { createWriteStream } = require('fs')
8-
const { unlink } = require('fs').promises
9-
const path = require('path')
7+
const { createWriteStream } = require('node:fs')
8+
const { unlink } = require('node:fs').promises
9+
const path = require('node:path')
1010
const { generateId } = require('./lib/generateId')
11-
const util = require('util')
11+
const util = require('node:util')
1212
const createError = require('@fastify/error')
1313
const sendToWormhole = require('stream-wormhole')
1414
const deepmergeAll = require('@fastify/deepmerge')({ all: true })
15-
const { PassThrough, pipeline, Readable } = require('stream')
15+
const { PassThrough, pipeline, Readable } = require('node:stream')
1616
const pump = util.promisify(pipeline)
1717
const secureJSON = require('secure-json-parse')
1818

‎test/big.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
7+
const http = require('node:http')
88
const stream = require('readable-stream')
99
const Readable = stream.Readable
1010
const pump = stream.pipeline
11-
const crypto = require('crypto')
11+
const crypto = require('node:crypto')
1212
const sendToWormhole = require('stream-wormhole')
1313

1414
// skipping on Github Actions because it takes too long

‎test/fix-313.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
10-
const { access } = require('fs').promises
11-
const EventEmitter = require('events')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
10+
const { access } = require('node:fs').promises
11+
const EventEmitter = require('node:events')
1212
const { once } = EventEmitter
1313

1414
const filePath = path.join(__dirname, '../README.md')

‎test/legacy/append-body.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ const test = require('tap').test
33
const FormData = require('form-data')
44
const Fastify = require('fastify')
55
const multipart = require('./../..')
6-
const http = require('http')
7-
const path = require('path')
8-
const fs = require('fs')
6+
const http = require('node:http')
7+
const path = require('node:path')
8+
const fs = require('node:fs')
99
const pump = require('pump')
1010

1111
const filePath = path.join(__dirname, '..', '..', 'README.md')

‎test/legacy/big.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('./../..')
7-
const http = require('http')
7+
const http = require('node:http')
88
const stream = require('readable-stream')
99
const Readable = stream.Readable
1010
const Writable = stream.Writable
1111
const pump = stream.pipeline
1212
const eos = stream.finished
13-
const crypto = require('crypto')
13+
const crypto = require('node:crypto')
1414

1515
// skipping on Github Actions because it takes too long
1616
test('should upload a big file in constant memory', { skip: process.env.CI }, function (t) {

‎test/legacy/multipart.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
'use strict'
2-
const os = require('os')
2+
const os = require('node:os')
33
const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('./../..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
1010
const concat = require('concat-stream')
1111
const stream = require('readable-stream')
1212
const pump = stream.pipeline

‎test/multipart-ajv-file.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
const test = require('tap').test
44
const Fastify = require('fastify')
55
const FormData = require('form-data')
6-
const http = require('http')
6+
const http = require('node:http')
77
const multipart = require('..')
8-
const { once } = require('events')
9-
const fs = require('fs')
10-
const path = require('path')
8+
const { once } = require('node:events')
9+
const fs = require('node:fs')
10+
const path = require('node:path')
1111

1212
const filePath = path.join(__dirname, '../README.md')
1313

‎test/multipart-attach-body.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
10-
const { once } = require('events')
11-
const { Readable } = require('stream')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
10+
const { once } = require('node:events')
11+
const { Readable } = require('node:stream')
1212
const pump = require('pump')
1313
const { writableNoopStream } = require('noop-stream')
1414

‎test/multipart-big-stream.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const crypto = require('crypto')
7+
const http = require('node:http')
8+
const crypto = require('node:crypto')
99
const { Readable } = require('readable-stream')
1010
const sendToWormhole = require('stream-wormhole')
11-
const EventEmitter = require('events')
11+
const EventEmitter = require('node:events')
1212
const { once } = EventEmitter
1313

1414
test('should emit fileSize limitation error during streaming', async function (t) {

‎test/multipart-body-schema.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
1010

1111
const filePath = path.join(__dirname, '../README.md')
1212

‎test/multipart-concat.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
1010

1111
const filePath = path.join(__dirname, '../README.md')
1212

‎test/multipart-disk.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const crypto = require('crypto')
7+
const http = require('node:http')
8+
const crypto = require('node:crypto')
99
const { Readable } = require('readable-stream')
10-
const path = require('path')
11-
const fs = require('fs')
12-
const { access } = require('fs').promises
13-
const EventEmitter = require('events')
10+
const path = require('node:path')
11+
const fs = require('node:fs')
12+
const { access } = require('node:fs').promises
13+
const EventEmitter = require('node:events')
1414
const { once } = EventEmitter
1515

1616
const filePath = path.join(__dirname, '../README.md')

‎test/multipart-duplicate-save-request-file.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
10-
const EventEmitter = require('events')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
10+
const EventEmitter = require('node:events')
1111
const { once } = EventEmitter
1212

1313
const filePath = path.join(__dirname, '../README.md')

‎test/multipart-empty-body.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const { once } = require('events')
7+
const http = require('node:http')
8+
const { once } = require('node:events')
99

1010
test('should not break with a empty request body when attachFieldsToBody is true', async function (t) {
1111
t.plan(5)

‎test/multipart-fileLimit.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
'use strict'
22

3-
const fs = require('fs')
4-
const crypto = require('crypto')
3+
const fs = require('node:fs')
4+
const crypto = require('node:crypto')
55
const test = require('tap').test
66
const FormData = require('form-data')
77
const Fastify = require('fastify')
88
const multipart = require('..')
9-
const http = require('http')
10-
const EventEmitter = require('events')
9+
const http = require('node:http')
10+
const EventEmitter = require('node:events')
1111
const { once } = EventEmitter
1212

1313
test('should throw fileSize limitation error when consuming the stream', async function (t) {

‎test/multipart-http2.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
77
const h2url = require('h2url')
8-
const path = require('path')
9-
const fs = require('fs')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
1010
const sendToWormhole = require('stream-wormhole')
1111

1212
const filePath = path.join(__dirname, '../README.md')

‎test/multipart-incomplete-upload.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
'use strict'
22

3-
const util = require('util')
3+
const util = require('node:util')
44
const test = require('tap').test
55
const FormData = require('form-data')
66
const Fastify = require('fastify')
77
const multipart = require('..')
8-
const http = require('http')
8+
const http = require('node:http')
99
const sleep = util.promisify(setTimeout)
1010
const { writableNoopStream } = require('noop-stream')
11-
const stream = require('stream')
11+
const stream = require('node:stream')
1212
const pipeline = util.promisify(stream.pipeline)
1313

1414
test('should finish with error on partial upload', async function (t) {

‎test/multipart-json.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
7+
const http = require('node:http')
88

99
test('should parse JSON fields forms if content-type is set', function (t) {
1010
t.plan(5)

‎test/multipart-security.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
10-
const crypto = require('crypto')
11-
const EventEmitter = require('events')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
10+
const crypto = require('node:crypto')
11+
const EventEmitter = require('node:events')
1212
const { once } = EventEmitter
1313

1414
const filePath = path.join(__dirname, '../README.md')

‎test/multipart-small-stream.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ const test = require('tap').test
44
const FormData = require('form-data')
55
const Fastify = require('fastify')
66
const multipart = require('..')
7-
const http = require('http')
8-
const path = require('path')
9-
const fs = require('fs')
10-
const EventEmitter = require('events')
7+
const http = require('node:http')
8+
const path = require('node:path')
9+
const fs = require('node:fs')
10+
const EventEmitter = require('node:events')
1111
const sendToWormhole = require('stream-wormhole')
1212
const { once } = EventEmitter
1313

‎test/multipart.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
'use strict'
22

3-
const util = require('util')
3+
const util = require('node:util')
44
const test = require('tap').test
55
const FormData = require('form-data')
66
const Fastify = require('fastify')
77
const multipart = require('..')
8-
const http = require('http')
9-
const path = require('path')
10-
const fs = require('fs')
8+
const http = require('node:http')
9+
const path = require('node:path')
10+
const fs = require('node:fs')
1111
const concat = require('concat-stream')
12-
const stream = require('stream')
13-
const { once } = require('events')
12+
const stream = require('node:stream')
13+
const { once } = require('node:events')
1414
const pump = util.promisify(stream.pipeline)
1515
const sendToWormhole = require('stream-wormhole')
1616

‎tester.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict'
22

3-
const http = require('http')
4-
const Readable = require('stream').Readable
3+
const http = require('node:http')
4+
const Readable = require('node:stream').Readable
55
const FormData = require('form-data')
66
const pump = require('pump')
77
const knownLength = 1024 * 1024 * 1024

0 commit comments

Comments
 (0)