Skip to content

Commit 03fc908

Browse files
FdawgsFdawgs
authored
refactor: move linting, dep checks, and license checks to own workflow (#178)
1 parent c898d5e commit 03fc908

File tree

8 files changed

+151
-469
lines changed

8 files changed

+151
-469
lines changed

‎.github/workflows/plugins-ci-elasticsearch.yml‎

Lines changed: 8 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -35,77 +35,19 @@ on:
3535
type: string
3636

3737
jobs:
38-
dependency-review:
39-
name: Dependency Review
40-
if: github.event_name == 'pull_request'
41-
runs-on: ubuntu-latest
38+
quality-check:
39+
uses: ./.github/workflows/plugins-ci-quality.yml
4240
permissions:
4341
contents: read
44-
steps:
45-
- name: Check out repo
46-
uses: actions/checkout@v4
47-
with:
48-
persist-credentials: false
49-
50-
- name: Dependency review
51-
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1
52-
53-
license-check:
54-
if: >
55-
!failure() &&
56-
!cancelled() &&
57-
inputs.license-check == true
58-
name: Check Licenses
59-
runs-on: ubuntu-latest
60-
permissions:
61-
contents: read
62-
steps:
63-
- uses: actions/checkout@v4
64-
with:
65-
persist-credentials: false
66-
67-
- name: Setup Node
68-
uses: actions/setup-node@v4
69-
with:
70-
check-latest: true
71-
node-version: lts/*
72-
73-
- name: Install dependencies
74-
run: npm i --ignore-scripts
75-
76-
- name: Check Licenses
77-
env:
78-
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
79-
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
80-
linter:
81-
name: Lint Code
82-
if: >
83-
!failure() &&
84-
!cancelled() &&
85-
inputs.lint == true
86-
runs-on: ubuntu-latest
87-
permissions:
88-
contents: read
89-
steps:
90-
- name: Check out repo
91-
uses: actions/checkout@v4
92-
with:
93-
persist-credentials: false
94-
95-
- name: Setup Node
96-
uses: actions/setup-node@v4
97-
with:
98-
check-latest: true
99-
node-version: lts/*
100-
101-
- name: Install dependencies
102-
run: npm i --ignore-scripts
103-
104-
- name: Lint code
105-
run: npm run lint
42+
secrets: inherit
43+
with:
44+
license-check: ${{ inputs.license-check }}
45+
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
46+
lint: ${{ inputs.lint }}
10647

10748
test:
10849
name: Node.js ${{ matrix.node-version }}
50+
needs: quality-check
10951
runs-on: ubuntu-latest
11052
strategy:
11153
matrix:

‎.github/workflows/plugins-ci-kafka.yml‎

Lines changed: 8 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -30,77 +30,19 @@ on:
3030
type: string
3131

3232
jobs:
33-
dependency-review:
34-
name: Dependency Review
35-
if: github.event_name == 'pull_request'
36-
runs-on: ubuntu-latest
37-
permissions:
38-
contents: read
39-
steps:
40-
- name: Check out repo
41-
uses: actions/checkout@v4
42-
with:
43-
persist-credentials: false
44-
45-
- name: Dependency review
46-
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1
47-
48-
license-check:
49-
if: >
50-
!failure() &&
51-
!cancelled() &&
52-
inputs.license-check == true
53-
name: Check Licenses
54-
runs-on: ubuntu-latest
33+
quality-check:
34+
uses: ./.github/workflows/plugins-ci-quality.yml
5535
permissions:
5636
contents: read
57-
steps:
58-
- uses: actions/checkout@v4
59-
with:
60-
persist-credentials: false
61-
62-
- name: Setup Node
63-
uses: actions/setup-node@v4
64-
with:
65-
check-latest: true
66-
node-version: lts/*
67-
68-
- name: Install dependencies
69-
run: npm i --ignore-scripts
70-
71-
- name: Check Licenses
72-
env:
73-
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
74-
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
75-
linter:
76-
name: Lint Code
77-
if: >
78-
!failure() &&
79-
!cancelled() &&
80-
inputs.lint == true
81-
runs-on: ubuntu-latest
82-
permissions:
83-
contents: read
84-
steps:
85-
- name: Check out repo
86-
uses: actions/checkout@v4
87-
with:
88-
persist-credentials: false
89-
90-
- name: Setup Node
91-
uses: actions/setup-node@v4
92-
with:
93-
check-latest: true
94-
node-version: lts/*
95-
96-
- name: Install dependencies
97-
run: npm i --ignore-scripts
98-
99-
- name: Lint code
100-
run: npm run lint
37+
secrets: inherit
38+
with:
39+
license-check: ${{ inputs.license-check }}
40+
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
41+
lint: ${{ inputs.lint }}
10142

10243
test:
10344
name: Node.js ${{ matrix.node-version }}
45+
needs: quality-check
10446
runs-on: ubuntu-latest
10547
strategy:
10648
matrix:

‎.github/workflows/plugins-ci-mongo.yml‎

Lines changed: 8 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -30,78 +30,19 @@ on:
3030
type: string
3131

3232
jobs:
33-
dependency-review:
34-
name: Dependency Review
35-
if: github.event_name == 'pull_request'
36-
runs-on: ubuntu-latest
33+
quality-check:
34+
uses: ./.github/workflows/plugins-ci-quality.yml
3735
permissions:
3836
contents: read
39-
steps:
40-
- name: Check out repo
41-
uses: actions/checkout@v4
42-
with:
43-
persist-credentials: false
44-
45-
- name: Dependency review
46-
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1
47-
48-
license-check:
49-
if: >
50-
!failure() &&
51-
!cancelled() &&
52-
inputs.license-check == true
53-
name: Check Licenses
54-
runs-on: ubuntu-latest
55-
permissions:
56-
contents: read
57-
steps:
58-
- uses: actions/checkout@v4
59-
with:
60-
persist-credentials: false
61-
62-
- name: Setup Node
63-
uses: actions/setup-node@v4
64-
with:
65-
check-latest: true
66-
node-version: lts/*
67-
68-
- name: Install dependencies
69-
run: npm i --ignore-scripts
70-
71-
- name: Check Licenses
72-
env:
73-
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
74-
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
75-
76-
linter:
77-
name: Lint Code
78-
if: >
79-
!failure() &&
80-
!cancelled() &&
81-
inputs.lint == true
82-
runs-on: ubuntu-latest
83-
permissions:
84-
contents: read
85-
steps:
86-
- name: Check out repo
87-
uses: actions/checkout@v4
88-
with:
89-
persist-credentials: false
90-
91-
- name: Setup Node
92-
uses: actions/setup-node@v4
93-
with:
94-
check-latest: true
95-
node-version: lts/*
96-
97-
- name: Install dependencies
98-
run: npm i --ignore-scripts
99-
100-
- name: Lint code
101-
run: npm run lint
37+
secrets: inherit
38+
with:
39+
license-check: ${{ inputs.license-check }}
40+
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
41+
lint: ${{ inputs.lint }}
10242

10343
test:
10444
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45+
needs: quality-check
10546
runs-on: ubuntu-latest
10647
permissions:
10748
contents: read

‎.github/workflows/plugins-ci-mysql.yml‎

Lines changed: 8 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -30,80 +30,19 @@ on:
3030
type: string
3131

3232
jobs:
33-
dependency-review:
34-
name: Dependency Review
35-
if: github.event_name == 'pull_request'
36-
runs-on: ubuntu-latest
37-
permissions:
38-
contents: read
39-
steps:
40-
- name: Check out repo
41-
uses: actions/checkout@v4
42-
with:
43-
persist-credentials: false
44-
45-
- name: Dependency review
46-
uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1
47-
48-
license-check:
49-
if: >
50-
!failure() &&
51-
!cancelled() &&
52-
inputs.license-check == true
53-
name: Check Licenses
54-
runs-on: ubuntu-latest
33+
quality-check:
34+
uses: ./.github/workflows/plugins-ci-quality.yml
5535
permissions:
5636
contents: read
57-
steps:
58-
- uses: actions/checkout@v4
59-
with:
60-
persist-credentials: false
61-
62-
- name: Setup Node
63-
uses: actions/setup-node@v4
64-
with:
65-
check-latest: true
66-
node-version: lts/*
67-
68-
- name: Install dependencies
69-
run: npm i --ignore-scripts
70-
71-
- name: Check Licenses
72-
env:
73-
ALLOWED_ADDITIONAL: ${{ inputs.license-check-allowed-additional }}
74-
run: npx license-checker --production --summary --onlyAllow="0BSD;Apache-2.0;BlueOak-1.0.0;BSD-2-Clause;BSD-3-Clause;ISC;MIT;$ALLOWED_ADDITIONAL"
75-
76-
linter:
77-
name: Lint Code
78-
if: >
79-
!failure() &&
80-
!cancelled() &&
81-
inputs.lint == true
82-
runs-on: ubuntu-latest
83-
permissions:
84-
contents: read
85-
steps:
86-
87-
- name: Check out repo
88-
uses: actions/checkout@v4
89-
with:
90-
persist-credentials: false
91-
92-
- name: Setup Node
93-
uses: actions/setup-node@v4
94-
with:
95-
check-latest: true
96-
node-version: lts/*
97-
98-
- name: Install dependencies
99-
run: npm i --ignore-scripts
100-
101-
- name: Lint code
102-
if: ${{ inputs.lint == true}}
103-
run: npm run lint
37+
secrets: inherit
38+
with:
39+
license-check: ${{ inputs.license-check }}
40+
license-check-allowed-additional: ${{ inputs.license-check-allowed-additional }}
41+
lint: ${{ inputs.lint }}
10442

10543
test:
10644
name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }}
45+
needs: quality-check
10746
runs-on: ubuntu-latest
10847
permissions:
10948
contents: read

0 commit comments

Comments
 (0)