Skip to content

Commit 34b2d5e

Browse files
authored
Rename acceptance test functions for logging blocks (#1157)
All of the acceptance test functions for logging blocks had names which started with the resource name, which did not cause a problem when only one type of resource was being tested. Now that both VCL and Compute resources are being tested, the function names have to be changed to put that detail in the 'flavor' part of the function name.
1 parent 451c634 commit 34b2d5e

28 files changed

+63
-63
lines changed

fastly/block_fastly_service_logging_bigquery_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
gofastly "github.com/fastly/go-fastly/v12/fastly"
1616
)
1717

18-
func TestAccFastlyServiceVCL_bigquerylogging_basic(t *testing.T) {
18+
func TestAccFastlyServiceLoggingBigQuery_vcl_basic(t *testing.T) {
1919
var service gofastly.ServiceDetail
2020
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2121
email := "[email protected]"
@@ -98,7 +98,7 @@ func TestAccFastlyServiceVCL_bigquerylogging_basic(t *testing.T) {
9898
})
9999
}
100100

101-
func TestAccFastlyServiceVCL_bigquerylogging_basic_compute(t *testing.T) {
101+
func TestAccFastlyServiceLoggingBigQuery_compute_basic(t *testing.T) {
102102
var service gofastly.ServiceDetail
103103
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
104104
email := "[email protected]"
@@ -139,7 +139,7 @@ func TestAccFastlyServiceVCL_bigquerylogging_basic_compute(t *testing.T) {
139139
})
140140
}
141141

142-
func TestAccFastlyServiceVCL_bigquerylogging_default(t *testing.T) {
142+
func TestAccFastlyServiceLoggingBigQuery_vcl_default(t *testing.T) {
143143
var service gofastly.ServiceDetail
144144
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
145145
email := "[email protected]"

fastly/block_fastly_service_logging_blobstorage_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
gofastly "github.com/fastly/go-fastly/v12/fastly"
1616
)
1717

18-
func TestAccFastlyServiceVCL_blobstoragelogging_basic(t *testing.T) {
18+
func TestAccFastlyServiceLoggingBlobstorage_vcl_basic(t *testing.T) {
1919
var service gofastly.ServiceDetail
2020
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2121

@@ -108,7 +108,7 @@ func TestAccFastlyServiceVCL_blobstoragelogging_basic(t *testing.T) {
108108
})
109109
}
110110

111-
func TestAccFastlyServiceVCL_blobstoragelogging_basic_compute(t *testing.T) {
111+
func TestAccFastlyServiceLoggingBlobstorage_compute_basic(t *testing.T) {
112112
var service gofastly.ServiceDetail
113113
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
114114

@@ -148,7 +148,7 @@ func TestAccFastlyServiceVCL_blobstoragelogging_basic_compute(t *testing.T) {
148148
})
149149
}
150150

151-
func TestAccFastlyServiceVCL_blobstoragelogging_default(t *testing.T) {
151+
func TestAccFastlyServiceLoggingBlobstorage_vcl_default(t *testing.T) {
152152
var service gofastly.ServiceDetail
153153
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
154154

fastly/block_fastly_service_logging_cloudfiles_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
gofastly "github.com/fastly/go-fastly/v12/fastly"
1616
)
1717

18-
func TestAccFastlyServiceVCL_logging_cloudfiles_basic(t *testing.T) {
18+
func TestAccFastlyServiceLoggingCloudfiles_vcl_basic(t *testing.T) {
1919
var service gofastly.ServiceDetail
2020
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2121
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -112,7 +112,7 @@ func TestAccFastlyServiceVCL_logging_cloudfiles_basic(t *testing.T) {
112112
})
113113
}
114114

115-
func TestAccFastlyServiceVCL_logging_cloudfiles_basic_compute(t *testing.T) {
115+
func TestAccFastlyServiceLoggingCloudfiles_compute_basic(t *testing.T) {
116116
var service gofastly.ServiceDetail
117117
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
118118
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_datadog_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
gofastly "github.com/fastly/go-fastly/v12/fastly"
1515
)
1616

17-
func TestAccFastlyServiceVCL_logging_datadog_basic(t *testing.T) {
17+
func TestAccFastlyServiceLoggingDatadog_vcl_basic(t *testing.T) {
1818
var service gofastly.ServiceDetail
1919
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2020
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -82,7 +82,7 @@ func TestAccFastlyServiceVCL_logging_datadog_basic(t *testing.T) {
8282
})
8383
}
8484

85-
func TestAccFastlyServiceVCL_logging_datadog_basic_compute(t *testing.T) {
85+
func TestAccFastlyServiceLoggingDatadog_compute_basic(t *testing.T) {
8686
var service gofastly.ServiceDetail
8787
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
8888
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_digitalocean_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
gofastly "github.com/fastly/go-fastly/v12/fastly"
1515
)
1616

17-
func TestAccFastlyServiceVCL_logging_digitalocean_basic(t *testing.T) {
17+
func TestAccFastlyServiceLoggingDigitalOcean_vcl_basic(t *testing.T) {
1818
var service gofastly.ServiceDetail
1919
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2020
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -111,7 +111,7 @@ func TestAccFastlyServiceVCL_logging_digitalocean_basic(t *testing.T) {
111111
})
112112
}
113113

114-
func TestAccFastlyServiceVCL_logging_digitalocean_basic_compute(t *testing.T) {
114+
func TestAccFastlyServiceLoggingDigitalOcean_compute_basic(t *testing.T) {
115115
var service gofastly.ServiceDetail
116116
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
117117
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_elasticsearch_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
gofastly "github.com/fastly/go-fastly/v12/fastly"
1515
)
1616

17-
func TestAccFastlyServiceVCL_logging_elasticsearch_basic(t *testing.T) {
17+
func TestAccFastlyServiceLoggingElasticsearch_vcl_basic(t *testing.T) {
1818
var service gofastly.ServiceDetail
1919
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2020
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -116,7 +116,7 @@ func TestAccFastlyServiceVCL_logging_elasticsearch_basic(t *testing.T) {
116116
})
117117
}
118118

119-
func TestAccFastlyServiceVCL_logging_elasticsearch_basic_compute(t *testing.T) {
119+
func TestAccFastlyServiceLoggingElasticsearch_compute_basic(t *testing.T) {
120120
var service gofastly.ServiceDetail
121121
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
122122
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_ftp_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
gofastly "github.com/fastly/go-fastly/v12/fastly"
1515
)
1616

17-
func TestAccFastlyServiceVCL_logging_ftp_basic(t *testing.T) {
17+
func TestAccFastlyServiceLoggingFTP_vcl_basic(t *testing.T) {
1818
var service gofastly.ServiceDetail
1919
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2020
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -111,7 +111,7 @@ func TestAccFastlyServiceVCL_logging_ftp_basic(t *testing.T) {
111111
})
112112
}
113113

114-
func TestAccFastlyServiceVCL_logging_ftp_basic_compute(t *testing.T) {
114+
func TestAccFastlyServiceLoggingFTP_compute_basic(t *testing.T) {
115115
var service gofastly.ServiceDetail
116116
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
117117
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_gcs_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
gofastly "github.com/fastly/go-fastly/v12/fastly"
1717
)
1818

19-
func TestAccFastlyServiceVCL_gcslogging_basic(t *testing.T) {
19+
func TestAccFastlyServiceLoggingGCS_vcl_basic(t *testing.T) {
2020
var service gofastly.ServiceDetail
2121
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2222
secretKey, err := generateKey()
@@ -113,7 +113,7 @@ func TestAccFastlyServiceVCL_gcslogging_basic(t *testing.T) {
113113
})
114114
}
115115

116-
func TestAccFastlyServiceVCL_gcslogging_basic_compute(t *testing.T) {
116+
func TestAccFastlyServiceLoggingGCS_compute_basic(t *testing.T) {
117117
var service gofastly.ServiceDetail
118118
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
119119
secretKey, err := generateKey()

fastly/block_fastly_service_logging_googlepubsub_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ func TestSecretKeySchemaDefaultFunc(t *testing.T) {
114114
}
115115
}
116116

117-
func TestAccFastlyServiceVCL_googlepubsublogging_basic(t *testing.T) {
117+
func TestAccFastlyServiceLoggingGooglePubSub_vcl_basic(t *testing.T) {
118118
var service gofastly.ServiceDetail
119119
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
120120
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -195,7 +195,7 @@ func TestAccFastlyServiceVCL_googlepubsublogging_basic(t *testing.T) {
195195
})
196196
}
197197

198-
func TestAccFastlyServiceVCL_googlepubsublogging_basic_compute(t *testing.T) {
198+
func TestAccFastlyServiceLoggingGooglePubSub_compute_basic(t *testing.T) {
199199
var service gofastly.ServiceDetail
200200
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
201201
domain := fmt.Sprintf("fastly-test.%s.com", name)

fastly/block_fastly_service_logging_grafanacloudlogs_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
gofastly "github.com/fastly/go-fastly/v12/fastly"
1515
)
1616

17-
func TestAccFastlyServiceVCL_logging_grafanacloudlogs_basic(t *testing.T) {
17+
func TestAccFastlyServiceLoggingGrafanaCloudLogs_vcl_basic(t *testing.T) {
1818
var service gofastly.ServiceDetail
1919
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
2020
domain := fmt.Sprintf("fastly-test.%s.com", name)
@@ -88,7 +88,7 @@ func TestAccFastlyServiceVCL_logging_grafanacloudlogs_basic(t *testing.T) {
8888
})
8989
}
9090

91-
func TestAccFastlyServiceVCL_logging_grafanacloudlogs_basic_compute(t *testing.T) {
91+
func TestAccFastlyServiceLoggingGrafanaCloudLogs_compute_basic(t *testing.T) {
9292
var service gofastly.ServiceDetail
9393
name := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
9494
domain := fmt.Sprintf("fastly-test.%s.com", name)

0 commit comments

Comments
 (0)