Skip to content

Conversation

@anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Nov 10, 2025

Change summary

Adjust tests to account for API changes. Seems like the default we were using no longer validates through the API so replaced it with a hardcoded string. The objects also changed so that deep equality no longer was usable so swapped to comparing the fields individually.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Post the output of your test runs
Screenshot 2025-11-10 at 4 21 38 PM Screenshot 2025-11-10 at 4 21 56 PM

@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review November 18, 2025 14:10
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner November 18, 2025 14:10
@anthony-gomez-fastly anthony-gomez-fastly merged commit e3a4a40 into main Nov 18, 2025
25 of 26 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the cdtool-1205-fix-logentries-tests branch November 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants