Ensure that mode updates are always sent when ddos_protection is enabled #1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Fixes #1148.
Previously, changes to ddos_protection.mode (e.g. from "block" to "log") were not sent to the Fastly API if the target mode was "log", due to a conditional check that skipped the update. This caused persistent diffs and unexpected behavior.
This pull request removes the conditional check and ensures that mode updates are always sent when ddos_protection is enabled.
All Submissions:
Changes to Core Features: