Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Nov 20, 2025

Change summary

This PR fixes a bug where the keepalive_time backend attribute was incorrectly being set to 0 in state when a value wasn't being set.

A more in depth explanation can be found here: https://fastly.atlassian.net/browse/CDTOOL-1225

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Post the output of your test runs
--- PASS: TestAccFastlyServiceVCLBackend_Minimal (9.28s)
PASS
ok   

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users should not longer see drift when updating backend objects in Terraform due to inconsistency between the keepalive_time attribute being changed from 0 -> null.

…com:fastly/terraform-provider-fastly into rcaril/CDTOOL-1225-fix-keepalive-time-drift
@rcaril rcaril marked this pull request as ready for review November 20, 2025 17:06
@rcaril rcaril requested a review from a team as a code owner November 20, 2025 17:06
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@rcaril rcaril merged commit 451c634 into main Nov 21, 2025
15 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1225-fix-keepalive-time-drift branch November 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants