Rename acceptance test functions for logging blocks #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
force-pushed
the
correct-acceptance-test-names
branch
from
77193aa to
ea796a1
Compare
kpfleming
changed the title
All of the acceptance test functions for logging blocks had names which started with the resource name, which did not cause a problem when only one type of resource was being tested. Now that both VCL and Compute resources are being tested, the function names have to be changed to put that detail in the 'flavor' part of the function name.
kpfleming
force-pushed
the
correct-acceptance-test-names
branch
from
46b065d to
d7a0279
Compare
anthony-gomez-fastly
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
All of the acceptance test functions for logging blocks had names which started with the resource name, which did not cause a problem when only one type of resource was being tested. Now that both VCL and Compute resources are being tested, the function names have to be changed to put that detail in the 'flavor' part of the function name.
All Submissions: