Skip to content

Revise boolean preservation test to trigger Update via connect_timeout #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippschulte merged 1 commit into from
Dec 3, 2025
Merged

Revise boolean preservation test to trigger Update via connect_timeout #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 46 additions & 30 deletions fastly/block_fastly_service_backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,76 +394,92 @@ resource "fastly_service_vcl" "foo" {
}`, serviceName, domainName, backendAddress, backendName, backendAddress, backendName, backendAddress, backendName, backendAddress, backendName)
}

func testAccServiceVCLBackendWithBooleans(serviceName, domainName, backendAddress, backendName string, useSSL, sslCheckCert, preferIPv6, autoLoadbalance bool) string {
return fmt.Sprintf(`
resource "fastly_service_vcl" "foo" {
name = "%s"

domain {
name = "%s"
}

backend {
address = "%s"
name = "%s"
use_ssl = %t
ssl_check_cert = %t
prefer_ipv6 = %t
auto_loadbalance = %t
port = 443
}

force_destroy = true
}`, serviceName, domainName, backendAddress, backendName, useSSL, sslCheckCert, preferIPv6, autoLoadbalance)
}

func TestAccFastlyServiceVCLBackend_PreserveBooleansDuringNameChange(t *testing.T) {
func TestAccFastlyServiceVCLBackend_BooleanFieldsPreservedOnTimeoutUpdate(t *testing.T) {
var service gofastly.ServiceDetail
serviceName := acctest.RandomWithPrefix("tf-backend")
domainName := fmt.Sprintf("test.%s.com", acctest.RandString(10))
backendAddress := "httpbin.org"

initialBackendName := "test-backend"
updatedBackendName := "test-backend-renamed"
backendName := "test-backend"

// Values we want to preserve
useSSL := true
sslCheckCert := false
preferIPv6 := true
autoLoadbalance := true

initialConnectTimeout := 1000
updatedConnectTimeout := 2000

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: testAccProviders,
CheckDestroy: testAccCheckServiceVCLDestroy,

Steps: []resource.TestStep{
// Step 1: Create
{
Config: testAccServiceVCLBackendWithBooleans(serviceName, domainName, backendAddress, initialBackendName, useSSL, sslCheckCert, preferIPv6, autoLoadbalance),
Config: testAccServiceVCLBackendWithBooleansAndConnectTimeout(
serviceName, domainName, backendAddress, backendName,
useSSL, sslCheckCert, preferIPv6, autoLoadbalance, initialConnectTimeout,
),
Check: resource.ComposeTestCheckFunc(
testAccCheckServiceExists("fastly_service_vcl.foo", &service),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.#", "1"),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.use_ssl", fmt.Sprintf("%t", useSSL)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.ssl_check_cert", fmt.Sprintf("%t", sslCheckCert)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.prefer_ipv6", fmt.Sprintf("%t", preferIPv6)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.auto_loadbalance", fmt.Sprintf("%t", autoLoadbalance)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.connect_timeout", fmt.Sprintf("%d", initialConnectTimeout)),
),
},
// Step 2: Update connect_timeout only
{
// Change name only, rest stays the same
Config: testAccServiceVCLBackendWithBooleans(serviceName, domainName, backendAddress, updatedBackendName, useSSL, sslCheckCert, preferIPv6, autoLoadbalance),
Config: testAccServiceVCLBackendWithBooleansAndConnectTimeout(
serviceName, domainName, backendAddress, backendName,
useSSL, sslCheckCert, preferIPv6, autoLoadbalance, updatedConnectTimeout,
),
Check: resource.ComposeTestCheckFunc(
testAccCheckServiceExists("fastly_service_vcl.foo", &service),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.#", "1"),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.use_ssl", fmt.Sprintf("%t", useSSL)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.ssl_check_cert", fmt.Sprintf("%t", sslCheckCert)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.prefer_ipv6", fmt.Sprintf("%t", preferIPv6)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.auto_loadbalance", fmt.Sprintf("%t", autoLoadbalance)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "backend.0.connect_timeout", fmt.Sprintf("%d", updatedConnectTimeout)),
),
},
},
})
}

func testAccServiceVCLBackendWithBooleansAndConnectTimeout(
serviceName, domainName, backendAddress, backendName string,
useSSL, sslCheckCert, preferIPv6, autoLoadbalance bool,
connectTimeout int,
) string {
return fmt.Sprintf(`
resource "fastly_service_vcl" "foo" {
name = "%s"

domain {
name = "%s"
}

backend {
address = "%s"
name = "%s"
use_ssl = %t
ssl_check_cert = %t
prefer_ipv6 = %t
auto_loadbalance = %t
connect_timeout = %d
}

force_destroy = true
}`, serviceName, domainName, backendAddress, backendName,
useSSL, sslCheckCert, preferIPv6, autoLoadbalance, connectTimeout)
}

func TestAccFastlyServiceVCLBackend_Minimal(t *testing.T) {
var service gofastly.ServiceDetail
serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
Expand Down