Skip to content

Conversation

@philippschulte
Copy link
Member

Change summary

This PR updates the acceptance test for preserving optional boolean fields in the logging_kafka block to ensure it actually exercises the Update() path.

Previously, the test modified only the name field — which causes a resource recreation due to ForceNew behavior. As a result, the test didn't confirm that use_tls and parse_log_keyvals were preserved during an update, defeating the purpose of the fix introduced in #1147.

To correct this:

  • The new test modifies a safe, non-ForceNew field: request_max_bytes
  • name remains constant to ensure an in-place update
  • Boolean fields are explicitly verified before and after the update

Outcome:

  • Ensures Update() is invoked
  • Validates use_tls and parse_log_keyvals are preserved as expected

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@philippschulte philippschulte requested a review from a team as a code owner December 3, 2025 05:09
@philippschulte philippschulte added the Skip-Changelog Skip changelog build check label Dec 3, 2025
@philippschulte philippschulte merged commit 49b7f97 into fastly:main Dec 4, 2025
12 checks passed
@philippschulte philippschulte deleted the pschulte/fix-kafka-boolean-preservation-test branch December 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog Skip changelog build check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants