Skip to content

Revise boolean preservation test to trigger Update via request_max_bytes #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippschulte merged 2 commits into from
Dec 4, 2025
Merged

Revise boolean preservation test to trigger Update via request_max_bytes #1163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d79efa
test(logging_kafka): update boolean preservation test to trigger Upda…
philippschulte Dec 3, 2025
672ee42
Merge branch 'main' into pschulte/fix-kafka-boolean-preservation-test
philippschulte Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions fastly/block_fastly_service_logging_kafka_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,40 +236,45 @@ func TestAccFastlyServiceLoggingKafka_compute_basic(t *testing.T) {
})
}

func TestAccFastlyServiceLoggingKafka_vcl_PreserveBooleansDuringNameChange(t *testing.T) {
func TestAccFastlyServiceLoggingKafka_BooleanFieldsPreservedOnUpdate(t *testing.T) {
var service gofastly.ServiceDetail
serviceName := acctest.RandomWithPrefix("tf-kafka")
domainName := fmt.Sprintf("test.%s.com", acctest.RandString(10))

initialKafkaName := "kafka-preserve"
updatedKafkaName := "kafka-preserve-renamed"
kafkaName := "kafka-logging-preserve"

// Values we want to preserve
useTLS := true
parseLogKeyvals := true

initialMaxBytes := 10000
updatedMaxBytes := 20000

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: testAccProviders,
CheckDestroy: testAccCheckServiceVCLDestroy,
Steps: []resource.TestStep{
{
Config: testAccServiceVCLKafkaLoggingPreserveBooleans(serviceName, domainName, initialKafkaName, useTLS, parseLogKeyvals),
Config: testAccServiceVCLKafkaLoggingPreserveBooleansWithMaxBytes(
serviceName, domainName, kafkaName, useTLS, parseLogKeyvals, initialMaxBytes),
Check: resource.ComposeTestCheckFunc(
testAccCheckServiceExists("fastly_service_vcl.foo", &service),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.#", "1"),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.use_tls", fmt.Sprintf("%t", useTLS)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.parse_log_keyvals", fmt.Sprintf("%t", parseLogKeyvals)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.request_max_bytes", fmt.Sprintf("%d", initialMaxBytes)),
),
},
{
// Only change the Kafka logging name (unrelated field), verify booleans are preserved
Config: testAccServiceVCLKafkaLoggingPreserveBooleans(serviceName, domainName, updatedKafkaName, useTLS, parseLogKeyvals),
// Only update non-ForceNew field: request_max_bytes
Config: testAccServiceVCLKafkaLoggingPreserveBooleansWithMaxBytes(
serviceName, domainName, kafkaName, useTLS, parseLogKeyvals, updatedMaxBytes),
Check: resource.ComposeTestCheckFunc(
testAccCheckServiceExists("fastly_service_vcl.foo", &service),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.#", "1"),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.use_tls", fmt.Sprintf("%t", useTLS)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.parse_log_keyvals", fmt.Sprintf("%t", parseLogKeyvals)),
resource.TestCheckResourceAttr("fastly_service_vcl.foo", "logging_kafka.0.request_max_bytes", fmt.Sprintf("%d", updatedMaxBytes)),
),
},
},
Expand Down Expand Up @@ -492,7 +497,11 @@ resource "fastly_service_vcl" "foo" {
}`, name, domain, format, format)
}

func testAccServiceVCLKafkaLoggingPreserveBooleans(serviceName, domainName, kafkaName string, useTLS, parseLogKeyvals bool) string {
func testAccServiceVCLKafkaLoggingPreserveBooleansWithMaxBytes(
serviceName, domainName, kafkaName string,
useTLS, parseLogKeyvals bool,
requestMaxBytes int,
) string {
return fmt.Sprintf(`
resource "fastly_service_vcl" "foo" {
name = "%s"
Expand All @@ -514,9 +523,10 @@ resource "fastly_service_vcl" "foo" {
required_acks = "1"
use_tls = %t
parse_log_keyvals = %t
request_max_bytes = %d
}

force_destroy = true
}
`, serviceName, domainName, kafkaName, useTLS, parseLogKeyvals)
`, serviceName, domainName, kafkaName, useTLS, parseLogKeyvals, requestMaxBytes)
}