Skip to content

Conversation

@philippschulte
Copy link
Member

Change summary

This PR resolves an issue related to the force_miss, force_ssl, bypass_busy_wait, and timer_support optional boolean fields in the request_setting block.

In Terraform, schema.TypeBool with Optional: true cannot distinguish between an unset value and one explicitly set to false. As a result, during updates involving unrelated field changes (e.g., default_host), these optional booleans could be omitted from the Fastly API update request — leading to unintended resets or configuration drift.

To prevent this, these optional booleans are now always included in the update payload, regardless of whether they’ve changed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Testing

  • Added new acceptance test for preserving optional bool values:
=== RUN TestAccFastlyServiceVCLRequestSetting_PreserveBooleansDuringUpdate
=== PAUSE TestAccFastlyServiceVCLRequestSetting_PreserveBooleansDuringUpdate
=== CONT TestAccFastlyServiceVCLRequestSetting_PreserveBooleansDuringUpdate
--- PASS: TestAccFastlyServiceVCLRequestSetting_PreserveBooleansDuringUpdate (31.03s)
  • Verified that existing acceptance tests for request_setting continue to pass:
=== RUN TestAccFastlyServiceVCLRequestSetting_basic
=== PAUSE TestAccFastlyServiceVCLRequestSetting_basic
=== CONT TestAccFastlyServiceVCLRequestSetting_basic
--- PASS: TestAccFastlyServiceVCLRequestSetting_basic (54.55s)

@philippschulte philippschulte requested a review from a team as a code owner December 5, 2025 21:09
@philippschulte philippschulte requested a review from rcaril December 5, 2025 21:09
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philippschulte philippschulte merged commit 29fdfdf into fastly:main Dec 8, 2025
23 checks passed
@philippschulte philippschulte deleted the pschulte/CDTOOL-1233_ensure-proper-optional-bool-behavior-in-request-settings branch December 8, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants