[CDTOOL-1233] ensure proper optional bool behavior in request_setting #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR resolves an issue related to the
force_miss,force_ssl,bypass_busy_wait, andtimer_supportoptional boolean fields in therequest_settingblock.In Terraform,
schema.TypeBoolwithOptional: truecannot distinguish between an unset value and one explicitly set tofalse. As a result, during updates involving unrelated field changes (e.g.,default_host), these optional booleans could be omitted from the Fastly API update request — leading to unintended resets or configuration drift.To prevent this, these optional booleans are now always included in the update payload, regardless of whether they’ve changed.
All Submissions:
Testing
request_settingcontinue to pass: