Protect active sessions from empty cleanup

Skip automatic empty-session cleanup for active and finalizing recordings, matching the existing running-batch protection.

Author: ComputelessComputer

apps/desktop/src/shared/desktop-tab-lifecycle.test.ts

@@ -100,27 +100,29 @@ describe("desktop tab lifecycle", () => {
       );
     });
 
-    it("skips cleanup for active batch sessions and non-session tabs", () => {
-      const invalidateSessionResource = vi.fn();
-      const deleteSessionFn = vi.fn();
-      const handler = createSessionTabCloseHandler({
-        store: {} as Parameters<
-          typeof createSessionTabCloseHandler
-        >[0]["store"],
-        indexes: {} as Parameters<
-          typeof createSessionTabCloseHandler
-        >[0]["indexes"],
-        invalidateSessionResource,
-        getSessionMode: vi.fn().mockReturnValue("running_batch"),
-        isSessionEmptyFn: vi.fn().mockReturnValue(true),
-        deleteSessionFn,
-      });
+    it("skips cleanup for non-inactive sessions and non-session tabs", () => {
+      for (const sessionMode of ["active", "finalizing", "running_batch"]) {
+        const invalidateSessionResource = vi.fn();
+        const deleteSessionFn = vi.fn();
+        const handler = createSessionTabCloseHandler({
+          store: {} as Parameters<
+            typeof createSessionTabCloseHandler
+          >[0]["store"],
+          indexes: {} as Parameters<
+            typeof createSessionTabCloseHandler
+          >[0]["indexes"],
+          invalidateSessionResource,
+          getSessionMode: vi.fn().mockReturnValue(sessionMode),
+          isSessionEmptyFn: vi.fn().mockReturnValue(true),
+          deleteSessionFn,
+        });
 
-      handler(createSessionTab({ id: "session-2" }));
-      handler(createContactsTab());
+        handler(createSessionTab({ id: `session-${sessionMode}` }));
+        handler(createContactsTab());
 
-      expect(invalidateSessionResource).not.toHaveBeenCalled();
-      expect(deleteSessionFn).not.toHaveBeenCalled();
+        expect(invalidateSessionResource).not.toHaveBeenCalled();
+        expect(deleteSessionFn).not.toHaveBeenCalled();
+      }
     });
   });
 });

apps/desktop/src/shared/desktop-tab-lifecycle.ts

@@ -72,7 +72,12 @@ export function createSessionTabCloseHandler({
     }
 
     const sessionId = tab.id;
-    if (getSessionMode(sessionId) === "running_batch") {
+    const sessionMode = getSessionMode(sessionId);
+    if (
+      sessionMode === "active" ||
+      sessionMode === "finalizing" ||
+      sessionMode === "running_batch"
+    ) {
       return;
     }