fix(stt): stabilize batch completion notifications

Use unique batch completion notification keys and recover session IDs from notification keys when sources are missing.

Author: ComputelessComputer

apps/desktop/src/services/event-listeners.test.tsx

@@ -4,6 +4,7 @@ import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
 import { EventListeners } from "./event-listeners";
 
 import { createAutoStopEndedNotificationKey } from "~/stt/auto-stop-notification";
+import { createBatchCompletedNotificationKey } from "~/stt/batch-completed-notification";
 
 const {
   notificationListenMock,
@@ -233,6 +234,34 @@ describe("EventListeners notification events", () => {
     });
   });
 
+  test("notification_confirm with batch key opens that session without source", async () => {
+    useMainStoreMock.mockReturnValue({} as never);
+
+    render(<EventListeners />);
+
+    await vi.waitFor(() =>
+      expect(notificationListenMock).toHaveBeenCalledTimes(1),
+    );
+
+    const handler = notificationListenMock.mock.calls[0]?.[0];
+    expect(handler).toBeTypeOf("function");
+
+    handler({
+      payload: {
+        type: "notification_confirm",
+        key: createBatchCompletedNotificationKey("session-1"),
+        source: null,
+      },
+    });
+
+    expect(createSessionMock).not.toHaveBeenCalled();
+    expect(openNewMock).toHaveBeenCalledWith({
+      type: "sessions",
+      id: "session-1",
+      state: { view: null, autoStart: null },
+    });
+  });
+
   test("notification_confirm with mic_detected source sets triggerAppIds (regression: #5120 confirm path)", async () => {
     useMainStoreMock.mockReturnValue({} as never);
 

apps/desktop/src/services/event-listeners.tsx

@@ -17,6 +17,7 @@ import * as settings from "~/store/tinybase/store/settings";
 import { listenerStore } from "~/store/zustand/listener/instance";
 import { useTabs } from "~/store/zustand/tabs";
 import { parseAutoStopEndedNotificationKey } from "~/stt/auto-stop-notification";
+import { parseBatchCompletedNotificationKey } from "~/stt/batch-completed-notification";
 
 type MainStore = NonNullable<ReturnType<typeof main.UI.useStore>>;
 
@@ -179,7 +180,7 @@ function useNotificationEvents() {
           const sourceSessionId =
             payload.source?.type === "session"
               ? payload.source.session_id
-              : null;
+              : parseBatchCompletedNotificationKey(payload.key);
           const triggerAppIds =
             payload.source?.type === "mic_detected"
               ? (payload.source.app_ids ?? null)

apps/desktop/src/store/zustand/listener/general-batch.test.ts

@@ -1,7 +1,12 @@
 import { beforeEach, describe, expect, test, vi } from "vitest";
 
 import { EMPTY_BATCH_TRANSCRIPT_ERROR } from "./batch";
-import { runBatchSession } from "./general-batch";
+import {
+  runBatchSession,
+  showBatchCompletedNotification,
+} from "./general-batch";
+
+import { parseBatchCompletedNotificationKey } from "~/stt/batch-completed-notification";
 
 const {
   isFocusedMock,
@@ -217,15 +222,30 @@ describe("runBatchSession", () => {
       },
     );
 
-    expect(showNotificationMock).toHaveBeenCalledWith(
+    const notification = showNotificationMock.mock.calls[0]?.[0];
+    expect(notification).toEqual(
       expect.objectContaining({
-        key: "batch-completed-session-1",
         title: "Transcription complete",
         message: "Your transcript is ready.",
         action_label: "Open Anarlog",
         source: { type: "session", session_id: "session-1" },
       }),
     );
+    expect(parseBatchCompletedNotificationKey(notification.key)).toBe(
+      "session-1",
+    );
+  });
+
+  test("uses a fresh notification key for each batch completion", async () => {
+    await showBatchCompletedNotification("session-1", { force: true });
+    await showBatchCompletedNotification("session-1", { force: true });
+
+    const firstKey = showNotificationMock.mock.calls[0]?.[0].key;
+    const secondKey = showNotificationMock.mock.calls[1]?.[0].key;
+
+    expect(parseBatchCompletedNotificationKey(firstKey)).toBe("session-1");
+    expect(parseBatchCompletedNotificationKey(secondKey)).toBe("session-1");
+    expect(firstKey).not.toBe(secondKey);
   });
 
   test("forwards streamed progress events before completion", async () => {

apps/desktop/src/store/zustand/listener/general-batch.ts

@@ -15,6 +15,8 @@ import {
   type BatchState,
 } from "./batch";
 
+import { createBatchCompletedNotificationKey } from "~/stt/batch-completed-notification";
+
 type BatchStore = BatchActions & BatchState;
 
 async function shouldNotifyBatchCompleted() {
@@ -42,7 +44,7 @@ export async function showBatchCompletedNotification(
 
   try {
     const result = await notificationCommands.showNotification({
-      key: `batch-completed-${sessionId}`,
+      key: createBatchCompletedNotificationKey(sessionId),
       title: "Transcription complete",
       message: "Your transcript is ready.",
       timeout: null,

apps/desktop/src/stt/batch-completed-notification.ts

@@ -0,0 +1,32 @@
+const LEGACY_BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX = "batch-completed-";
+
+export const BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX =
+  "batch-completed:" as const;
+
+export function createBatchCompletedNotificationKey(sessionId: string) {
+  return `${BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX}${sessionId}:${crypto.randomUUID()}`;
+}
+
+export function parseBatchCompletedNotificationKey(
+  key: string | null | undefined,
+) {
+  if (!key) {
+    return null;
+  }
+
+  if (key.startsWith(BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX)) {
+    const value = key.slice(BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX.length);
+    const separatorIndex = value.lastIndexOf(":");
+    return (
+      value.slice(0, separatorIndex === -1 ? undefined : separatorIndex) || null
+    );
+  }
+
+  if (key.startsWith(LEGACY_BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX)) {
+    return (
+      key.slice(LEGACY_BATCH_COMPLETED_NOTIFICATION_KEY_PREFIX.length) || null
+    );
+  }
+
+  return null;
+}