fix(notes): add self participant to new notes#5299
Merged
Conversation
Create plain sessions through one helper so new notes include the current user participant while self-only blanks still clean up.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create plain sessions through one helper so new notes include the current user participant while self-only blanks still clean up.
Note
Medium Risk
Changes note/session creation and emptiness detection logic, which can affect session cleanup behavior and participant mappings across the app. Risk is moderate due to new transactional writes and default-user fallbacks, but scope is localized to session/participant creation.
Overview
New notes are now created via the shared
createSessionhelper fromuseNewNote,useNewNoteAndListen, anduseNewNoteAndUpload, removing the duplicated inline session-row creation and moving thenote_createdanalytics emission into the helper.createSessionnow assigns the current user (store.getValue("user_id")with aDEFAULT_USER_IDfallback) to the session and ensures the current user is added as a manual participant (creating a blankhumansrow if needed) in a single transaction; event-derived participant creation is also updated to use the current user.isSessionEmptyis adjusted so a note with only the default self participant is still considered empty, while additional non-auto participants count as content. Addedsessions.test.tsto cover self-participant creation, analytics firing, and the updated emptiness semantics.Reviewed by Cursor Bugbot for commit d5ce26f. Bugbot is set up for automated code reviews on this repo. Configure here.