fix(enhance): include note images in summaries#5422
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
8018a76 to
9d66acf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9d66acf. Configure here.
Read referenced image attachments for multimodal summary models and send them as AI SDK image parts. Add fs-sync attachment reading support and coverage.
9d66acf to
5a040b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Read referenced image attachments for multimodal summary models and send them as AI SDK image parts. Add fs-sync attachment reading support and coverage.
Note
Medium Risk
Adds local attachment reads and sends image bytes to external LLM APIs when vision models are selected; mitigated by model gating and size/count limits but still affects cost, latency, and note content exposure.
Overview
Enhance can now use note images as multimodal context when the selected LLM supports vision.
When the current provider/model passes
modelSupportsImageInput, the transform step gathers images from pre-meeting transcript memos and post-meeting sessionraw_md. References are parsed from TipTap JSON and markdown (asset:/// local attachment paths and inlinedata:URLs). Referenced session attachments are loaded via a newattachment_readfs-sync API (Rust core, Tauri command, JS bindings, default permissions), with caps of 10 images and 8MB per image.The enhance workflow attaches those images as AI SDK
ImageParts alongside the text prompt (template discovery and summary streaming) and adds a short instruction that attached images are visual context. Text-only models skip collection entirely.Tests cover model gating, image reference parsing, attachment reads, and transform wiring.
Reviewed by Cursor Bugbot for commit 5a040b2. Bugbot is set up for automated code reviews on this repo. Configure here.