fix(desktop): restore Soniqo on Sonoma#5438
Open
ComputelessComputer wants to merge 1 commit into
Open
Conversation
Keep the desktop macOS floor at 14.2, build the Soniqo Swift bridge for macOS 14, and leave macOS 15-only Qwen ASR unavailable.
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e756886. Configure here.
| Self::ParakeetStreaming, | ||
| Self::ParakeetBatch, | ||
| Self::Omnilingual, | ||
| ]; |
There was a problem hiding this comment.
Test expects Qwen3 models still in all()
Medium Severity
The ALL constant was changed to exclude Qwen3Small and Qwen3Large, but the existing test all_includes_every_model_variant still asserts that SoniqoModel::all() returns all five variants including both Qwen3 models. This test will now fail.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e756886. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the desktop macOS floor at 14.2, build the Soniqo Swift bridge for macOS 14, and leave macOS 15-only Qwen ASR unavailable.
Note
Medium Risk
Build-time manifest patching and deployment-target changes affect all macOS Soniqo builds; model catalog/availability semantics changed for Qwen vs other models.
Overview
Restores Soniqo on macOS 14 (Sonoma) by lowering the Swift bridge and Metal build from macOS 15 to 14.0, and keeps Qwen3 ASR off that path.
The macOS build now runs
swift package resolve, then patches the checked-outspeech-swiftPackage.swiftso its platform matches 14.0 before linking.soniqo-swiftdrops theQwen3ASRproduct; MLX Metal uses-mmacosx-version-min=14.0via a shared constant.On the Rust side,
SoniqoModel::all()only lists Parakeet and Omnilingual (what the app should surface on Sonoma), whileKNOWNstill parses Qwen IDs.is_available_on_current_platformexcludes Qwen on Apple Silicon, and the Swift bridge errors on Qwen load with a macOS 15 message instead of linking Qwen3 code.Reviewed by Cursor Bugbot for commit e756886. Bugbot is set up for automated code reviews on this repo. Configure here.