Hide empty transcript tabs#5556
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
f38aed3 to
c2e7b8c
Compare
c2e7b8c to
9023a60
Compare
9023a60 to
16627a3
Compare
5432b46 to
10e94eb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 10e94eb. Configure here.
2eefd73 to
47273a0
Compare
Treat transcript rows without words as empty and show related meetings without an empty transcript panel.
47273a0 to
c18b15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Treat transcript rows without words as empty and show related meetings without an empty transcript panel.
Note
Medium Risk
Changes session bottom-panel visibility and audio vs URL semantics across several UI entry points; behavior is well covered by new tests but affects post-session UX paths.
Overview
Treats “has transcript” as rows with actual words, not merely linked transcript IDs, so empty transcript storage no longer drives the bottom panel.
Splits audio presence from playback readiness:
audioExistscomes from the audio player query (URL is no longer treated as proof of existence), while playback waits onaudioUrlReadyand the post-session chrome can stay visible duringisAudioLoading.Bottom accessory behavior hides the Transcript tab when there is nothing to show (no words, no playback, no batch run), defaulting to Related meetings only; batch transcription errors still show the transcript tab/panel so failures remain visible. Expanded tests cover these cases.
Reviewed by Cursor Bugbot for commit c18b15b. Bugbot is set up for automated code reviews on this repo. Configure here.
This is part 1 of 2 in a stack made with GitButler: