Skip to content

Hide empty transcript tabs#5556

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/hide-empty-transcript-tab
Jun 12, 2026
Merged

Hide empty transcript tabs#5556
ComputelessComputer merged 1 commit into
mainfrom
fix/hide-empty-transcript-tab

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Treat transcript rows without words as empty and show related meetings without an empty transcript panel.


Note

Medium Risk
Changes session bottom-panel visibility and audio vs URL semantics across several UI entry points; behavior is well covered by new tests but affects post-session UX paths.

Overview
Treats “has transcript” as rows with actual words, not merely linked transcript IDs, so empty transcript storage no longer drives the bottom panel.

Splits audio presence from playback readiness: audioExists comes from the audio player query (URL is no longer treated as proof of existence), while playback waits on audioUrlReady and the post-session chrome can stay visible during isAudioLoading.

Bottom accessory behavior hides the Transcript tab when there is nothing to show (no words, no playback, no batch run), defaulting to Related meetings only; batch transcription errors still show the transcript tab/panel so failures remain visible. Expanded tests cover these cases.

Reviewed by Cursor Bugbot for commit c18b15b. Bugbot is set up for automated code reviews on this repo. Configure here.


This is part 1 of 2 in a stack made with GitButler:

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit c18b15b
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a2b9f204c90720007c5699e

Comment thread apps/desktop/src/session/components/bottom-accessory/index.tsx Outdated
Comment thread apps/desktop/src/session/index.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-transcript-tab branch from 9023a60 to 16627a3 Compare June 12, 2026 04:06
Comment thread apps/desktop/src/session/components/shared.tsx
Comment thread apps/desktop/src/audio-player/provider.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-transcript-tab branch 2 times, most recently from 5432b46 to 10e94eb Compare June 12, 2026 05:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 10e94eb. Configure here.

Comment thread apps/desktop/src/session/components/bottom-accessory/index.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-transcript-tab branch 2 times, most recently from 2eefd73 to 47273a0 Compare June 12, 2026 05:46
Treat transcript rows without words as empty and show related meetings without an empty transcript panel.
@ComputelessComputer ComputelessComputer force-pushed the fix/hide-empty-transcript-tab branch from 47273a0 to c18b15b Compare June 12, 2026 05:54
@ComputelessComputer ComputelessComputer merged commit 58c377b into main Jun 12, 2026
10 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/hide-empty-transcript-tab branch June 12, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant