Replace editor view polling with callbacks#5562
Merged
Merged
Conversation
Expose NoteEditor view lifecycle callbacks and use them in NoteInput instead of polling the editor ref after render.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose NoteEditor view lifecycle callbacks and use them in NoteInput instead of polling the editor ref after render.
Note
Low Risk
Localized editor lifecycle wiring for UI caret behavior; no auth, persistence, or API changes.
Overview
Replaces per-render polling of
internalEditorRef.current?.viewin session NoteInput with explicit ProseMirror view lifecycle hooks, so caret-near-bottom tracking gets a stableEditorViewwhen the editor mounts and clears it on teardown (e.g. raw ↔ enhanced tab switches).NoteEditorgains optionalonViewReady/onViewDisposedprops.ViewCapturenow runs disposal in theuseEditorEffectcleanup (with a ref for latest callbacks) and still invokes the internal ready path that seeds debouncedonUpdatebefore forwardingonViewReady. Raw, Enhanced, and EnhancedEditor pass these callbacks through unchanged.NoteInput wires
handleViewReady/handleViewDisposedinto both tab editors; dispose only nulls state when the disposed view matches the current one, avoiding races if a new view is already active.Reviewed by Cursor Bugbot for commit 791c919. Bugbot is set up for automated code reviews on this repo. Configure here.