Restore sidebar chrome drag region#5568
Merged
Merged
Conversation
Mark the sidebar timeline chrome wrappers as draggable while keeping the visible controls explicitly clickable.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the sidebar timeline chrome wrappers as draggable while keeping the visible controls explicitly clickable.
Note
Low Risk
Small desktop chrome attribute change with matching unit tests; no auth, data, or business-logic impact.
Overview
Restores Tauri window dragging on the sidebar timeline chrome by marking the chrome layout wrappers with
data-tauri-drag-region, so pointer events on padding/gaps move the frameless window again.Chrome controls stay explicitly non-draggable via existing
data-tauri-drag-region="false"onLeftSurfaceChromeButton(sidebar toggle, search, new note). Tests now assert the chrome wrappers are draggable and those buttons remainfalse.Reviewed by Cursor Bugbot for commit 2141f95. Bugbot is set up for automated code reviews on this repo. Configure here.