Restore pre-KakaoTalk summary wording

Roll back the direct-message recap rewrite in JournalGenerator.
Update journal tests to expect plain conversation titles again.

Author: ComputelessComputer

Sources/OpenbirdKit/Services/JournalGenerator.swift

@@ -196,12 +196,6 @@ public actor JournalGenerator {
         ]
 
         if dominantCategory(for: section) == .communication {
-            guidance.append(
-                "For chat or messaging evidence, participant or thread titles identify the conversation context, not automatically the speaker of each nearby message snippet."
-            )
-            guidance.append(
-                "If the excerpt does not explicitly identify who said a message, describe it as something discussed or coordinated rather than attributing it to a named person."
-            )
             guidance.append(
                 "If message cues are prefixed with `Me:` or `Them:`, preserve that attribution."
             )
@@ -291,30 +285,21 @@ public actor JournalGenerator {
     }
 
     private func eventPrompt(_ event: GroupedActivityEvent) -> String {
-        let isCommunicationEvent = communicationAppLabels.contains(event.appName.normalizedComparisonKey)
         var pieces = [
             "\(OpenbirdDateFormatting.timeString(for: event.startedAt))-\(OpenbirdDateFormatting.timeString(for: event.endedAt))",
             event.appName,
         ]
 
         if let detailTitle = event.detailTitle {
-            if isCommunicationEvent {
-                pieces.append("context: \(detailTitle)")
-            } else {
-                pieces.append(detailTitle)
-            }
+            pieces.append(detailTitle)
         }
 
         if let urlSummary = ActivityEvidencePreprocessor.summarizedURL(from: event.url) {
             pieces.append(urlSummary)
         }
 
         if event.excerpt.isEmpty == false {
-            if isCommunicationEvent {
-                pieces.append("message cues (speaker may be unclear): \(event.excerpt)")
-            } else {
-                pieces.append(event.excerpt)
-            }
+            pieces.append(event.excerpt)
         }
 
         if event.sourceEventCount > 1 {
@@ -435,10 +420,6 @@ public actor JournalGenerator {
     }
 
     private func storyHeadingLabel(for section: PreparedSection) -> String {
-        if let directMessageHeading = directMessageHeading(for: section) {
-            return directMessageHeading
-        }
-
         let topic = displayTopic(for: section)
         guard shouldRewriteHeading(topic, section: section),
               let context = bestStoryContext(for: section) else {
@@ -458,10 +439,6 @@ public actor JournalGenerator {
     }
 
     private func storyNarrativeLead(for section: PreparedSection, apps: [String]) -> String? {
-        if let directMessageLead = directMessageNarrativeLead(for: section, apps: apps) {
-            return directMessageLead
-        }
-
         guard shouldRewriteHeading(displayTopic(for: section), section: section),
               let context = bestStoryContext(for: section) else {
             return nil
@@ -493,48 +470,6 @@ public actor JournalGenerator {
         return genericToolLabels.contains(normalizedTopic)
     }
 
-    private func directMessageHeading(for section: PreparedSection) -> String? {
-        guard isDirectMessagingSection(section),
-              let conversationTitle = primaryConversationTitle(for: section) else {
-            return nil
-        }
-
-        return "Chatting with \(conversationTitle)"
-    }
-
-    private func directMessageNarrativeLead(for section: PreparedSection, apps: [String]) -> String? {
-        guard isDirectMessagingSection(section),
-              let conversationTitle = primaryConversationTitle(for: section),
-              let appName = apps.first else {
-            return nil
-        }
-
-        return "You were chatting with \(conversationTitle) on \(appName)."
-    }
-
-    private func isDirectMessagingSection(_ section: PreparedSection) -> Bool {
-        let appNames = Set(section.groupedEvents.map { $0.appName.normalizedComparisonKey })
-        return appNames.count == 1 && appNames.isDisjoint(with: directMessagingAppLabels) == false
-    }
-
-    private func primaryConversationTitle(for section: PreparedSection) -> String? {
-        section.groupedEvents
-            .compactMap(\.detailTitle)
-            .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) }
-            .first(where: isUsableConversationTitle)
-    }
-
-    private func isUsableConversationTitle(_ title: String) -> Bool {
-        let normalizedTitle = title.normalizedComparisonKey
-        guard normalizedTitle.isEmpty == false,
-              genericToolLabels.contains(normalizedTitle) == false
-        else {
-            return false
-        }
-
-        return normalizedTitle.replacingOccurrences(of: " ", with: "").allSatisfy(\.isNumber) == false
-    }
-
     private func bestStoryContext(for section: PreparedSection) -> String? {
         let topicKey = displayTopic(for: section).normalizedComparisonKey
 
@@ -676,10 +611,6 @@ public actor JournalGenerator {
         ["slack", "messages", "imessage", "discord", "kakaotalk", "telegram", "whatsapp", "mail", "gmail"]
     }
 
-    private var directMessagingAppLabels: Set<String> {
-        ["messages", "imessage", "kakaotalk", "telegram", "whatsapp"]
-    }
-
     private var developmentAppLabels: Set<String> {
         ["xcode", "visual studio code", "vs code", "cursor", "zed", "terminal", "iterm2", "warp", "nova"]
     }

Tests/OpenbirdKitTests/JournalGeneratorTests.swift

@@ -366,12 +366,12 @@ struct JournalGeneratorTests {
         #expect(journal.sections.first?.bullets.first?.contains("Enter a message") == false)
         #expect(journal.sections.first?.bullets.first?.contains("Voice Call") == false)
         #expect(journal.markdown.contains("Looked through your context."))
-        #expect(journal.markdown.contains("## Chatting with Alice"))
-        #expect(journal.markdown.contains("You were chatting with Alice on KakaoTalk."))
+        #expect(journal.markdown.contains("## Alice"))
+        #expect(journal.markdown.contains("This part of the day centered on Alice in KakaoTalk."))
         #expect(journal.markdown.contains("- See you there"))
     }
 
-    @Test func fallbackMarkdownTreatsDirectMessagesAsConversationContext() async throws {
+    @Test func fallbackMarkdownKeepsDirectMessageTitlesPlain() async throws {
         let databaseURL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString).appendingPathExtension("sqlite")
         let store = try OpenbirdStore(databaseURL: databaseURL)
         let generator = JournalGenerator(store: store)
@@ -403,9 +403,9 @@ struct JournalGeneratorTests {
             )
         )
 
-        #expect(journal.markdown.contains("## Chatting with 윤진솔"))
-        #expect(journal.markdown.contains("You were chatting with 윤진솔 on KakaoTalk."))
-        #expect(journal.markdown.contains("## 윤진솔") == false)
+        #expect(journal.markdown.contains("## 윤진솔"))
+        #expect(journal.markdown.contains("This part of the day centered on 윤진솔 in KakaoTalk."))
+        #expect(journal.markdown.contains("## Chatting with 윤진솔") == false)
     }
 
     @Test func compactsAcrossWholeDayWhenSourceEventsAreCapped() async throws {