Skip to content

Commit e44d69d

Browse files
authored
Rubocop: Fix all current warnings and enable further areas (#1489)
* Add devcontainer * Fix rubocop warning * Fix trailing whitespace * Fix redundant returns * Fix redundant returns * Style/RedundantRegexpEscape: Redundant escape inside regexp literal * Various rubocop tweaks * Rubocop: Use pipes, not ternary * Rubocop: Spacing * Rubocop: Spacing * More rubocop tweaks * Rubocop * Generate a lot of TODOs * Clean up false positives * Grandfather in old naming style * Rubocop * Permit legacy * Rename * Fix all current warnings * Rubocop
1 parent fa008e3 commit e44d69d

34 files changed

+1458
-289
lines changed

.rubocop.yml

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
inherit_from: .rubocop_todo.yml
22

3+
plugins:
4+
- rubocop-capybara
5+
- rubocop-factory_bot
6+
- rubocop-rails
7+
- rubocop-rspec
8+
- rubocop-rspec_rails
9+
310
AllCops:
4-
TargetRubyVersion: 3.3
11+
TargetRubyVersion: 3.4
12+
NewCops: enable
513

614
Bundler/OrderedGems:
715
Enabled: false
@@ -71,3 +79,29 @@ Style/WordArray:
7179

7280
Style/SymbolArray:
7381
EnforcedStyle: percent
82+
83+
RSpec/DescribeClass:
84+
Exclude:
85+
- 'spec/views/**/*_spec.rb'
86+
- 'spec/lib/errors_spec.rb'
87+
88+
# Arguably these should be fixed at a later point, but would require depreciation, aliases, etc.
89+
Naming/PredicatePrefix:
90+
Exclude:
91+
- 'spec/support/assert_select.rb'
92+
- 'app/inputs/date_time_input.rb'
93+
- 'app/models/users/user.rb'
94+
- 'lib/fat_free_crm/fields.rb'
95+
- 'lib/fat_free_crm/mail_processor/base.rb'
96+
97+
RSpec/SpecFilePathFormat:
98+
Exclude:
99+
- 'spec/routing/**/*.rb'
100+
- 'spec/lib/**/*.rb'
101+
102+
Rails/CreateTableWithTimestamps:
103+
Exclude:
104+
- 'db/migrate/20100928030600_create_openid_tables.rb'
105+
- 'db/migrate/20100928030617_drop_openid_tables.rb'
106+
- 'db/migrate/20230526211831_create_active_storage_tables.active_storage.rb'
107+
- 'db/migrate/20100928030627_acts_as_taggable_on_migration.rb'

0 commit comments

Comments
 (0)