Skip to content

Commit 05dfed7

Browse files
committed
chore: enhance MultiselectDropdown with button variant prop and update styling in WebhookForm
1 parent 16db0f7 commit 05dfed7

File tree

2 files changed

+29
-20
lines changed

2 files changed

+29
-20
lines changed

app/javascript/dashboard/routes/dashboard/settings/integrations/Webhooks/WebhookForm.vue

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -125,27 +125,32 @@ export default {
125125
:placeholder="webhookNameInputPlaceholder"
126126
/>
127127
</label>
128-
<div class="multiselect-wrap--small">
128+
<div class="flex flex-col w-full">
129129
<label>
130130
{{ $t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.LABEL') }}
131-
<MultiselectDropdown
132-
:options="inboxes"
133-
:selected-item="selectedInbox"
134-
:multiselector-title="
135-
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.TITLE')
136-
"
137-
:multiselector-placeholder="
138-
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.PLACEHOLDER')
139-
"
140-
:no-search-result="
141-
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.NO_RESULTS')
142-
"
143-
:input-placeholder="
144-
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.INPUT_PLACEHOLDER')
145-
"
146-
:disabled="isEditing"
147-
@select="onClickAssignInbox"
148-
/>
131+
<div
132+
class="multiselect-wrap--small form-container [&>.button]:w-full [&>.button]:px-4 [&>.button]:py-2 [&>.button]:rounded-md [&>.button]:border [&>.button]:border-gray-300 [&>.button]:text-gray-900 [&>.button]:bg-white [&>.button]:focus:outline-none [&>.button]:focus:ring-2 [&>.button]:focus:ring-blue-500 [&>.button]:focus:border-blue-500"
133+
>
134+
<MultiselectDropdown
135+
:options="inboxes"
136+
:selected-item="selectedInbox"
137+
:multiselector-title="
138+
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.TITLE')
139+
"
140+
:multiselector-placeholder="
141+
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.PLACEHOLDER')
142+
"
143+
:no-search-result="
144+
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.NO_RESULTS')
145+
"
146+
:input-placeholder="
147+
$t('INTEGRATION_SETTINGS.WEBHOOK.FORM.INBOX.INPUT_PLACEHOLDER')
148+
"
149+
:disabled="isEditing"
150+
button-variant="secondary"
151+
@select="onClickAssignInbox"
152+
/>
153+
</div>
149154
</label>
150155
</div>
151156
<label :class="{ error: v$.url.$error }" class="mb-2">

app/javascript/shared/components/ui/MultiselectDropdown.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ const props = defineProps({
3535
type: String,
3636
default: 'Search',
3737
},
38+
buttonVariant: {
39+
type: String,
40+
default: 'hollow',
41+
},
3842
disabled: {
3943
type: Boolean,
4044
default: false,
@@ -63,7 +67,7 @@ const hasValue = computed(() => {
6367
<div class="relative w-full mb-2" @keyup.esc="onCloseDropdown">
6468
<woot-button
6569
type="button"
66-
variant="hollow"
70+
:variant="buttonVariant"
6771
color-scheme="secondary"
6872
class="w-full px-2 border border-solid !border-n-weak dark:!border-n-weak hover:!border-n-strong dark:hover:!border-n-strong"
6973
:is-disabled="disabled"

0 commit comments

Comments
 (0)