feat: use the compact version of language select #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use the compacted version of the language selection on the header. When Richie changes the language cookie to be 'pt' the MFEs show any language on the header, so it is kind of strange. So now showing the language name on the header is better, it hides the problem and give us more space on the header, but still showning an easy way the learner to change it.
|
I agree with your logic here. Showing the incorrect language choice might cause confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use the compacted version of the language selection on the header. When Richie changes the language cookie to be 'pt' the MFEs show any language on the header, so it is kind of strange. So now showing the language name on the header is better, it hides the problem and give us more space on the header, but still showning an easy way the learner to change it.