Merge pull request #544 from fccview/develop

fix drag/drop for kanban when statuses are default

Author: fccview

app/_server/actions/checklist-item/drop.ts

@@ -10,6 +10,7 @@ import { broadcast } from "@/app/_server/ws/broadcast";
 import { applyDrop } from "@/app/_utils/kanban/board-utils";
 import { listToMarkdown } from "@/app/_utils/checklist-utils";
 import { CHECKLISTS_FOLDER } from "@/app/_consts/checklists";
+import { DEFAULT_KANBAN_STATUSES } from "@/app/_consts/kanban";
 import { Checklist, Result } from "@/app/_types";
 import { ItemTypes, PermissionTypes } from "@/app/_types/enums";
 
@@ -61,9 +62,11 @@ export const dropItem = async (
       return { success: false, error: "Item not found" };
     }
 
-    const isValidStatus = (list.statuses || []).some(
-      (s) => s.id === targetStatus,
-    );
+    const statuses =
+      list.statuses && list.statuses.length > 0
+        ? list.statuses
+        : DEFAULT_KANBAN_STATUSES;
+    const isValidStatus = statuses.some((s) => s.id === targetStatus);
     if (!isValidStatus) {
       return { success: false, error: "Invalid target status" };
     }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jotty.page",
-  "version": "1.25.0",
+  "version": "1.25.1",
   "private": true,
   "scripts": {
     "dev": "next dev",

tests/server-actions/drop-item.test.ts

@@ -190,6 +190,48 @@ describe("dropItem", () => {
     expect(mockServerWriteFile).not.toHaveBeenCalled();
   });
 
+  it("accepts a default status on a legacy board without explicit statuses", async () => {
+    const { statuses: _statuses, ...legacyBoard } = mockBoard;
+    mockGetListById.mockImplementation(async (id: string) =>
+      id === BOARD_UUID ? structuredClone(legacyBoard) : undefined,
+    );
+
+    const result = await dropItem(
+      createFormData({
+        uuid: BOARD_UUID,
+        itemId: "task-1",
+        targetStatus: "in_progress",
+        targetIndex: "0",
+      }),
+    );
+
+    expect(result.success).toBe(true);
+    expect(result.data!.items.find((i) => i.id === "task-1")?.status).toBe(
+      "in_progress",
+    );
+    expect(mockServerWriteFile).toHaveBeenCalledTimes(1);
+  });
+
+  it("rejects a target status that is not a default when none are defined", async () => {
+    const { statuses: _statuses, ...legacyBoard } = mockBoard;
+    mockGetListById.mockImplementation(async (id: string) =>
+      id === BOARD_UUID ? structuredClone(legacyBoard) : undefined,
+    );
+
+    const result = await dropItem(
+      createFormData({
+        uuid: BOARD_UUID,
+        itemId: "task-1",
+        targetStatus: "nonsense",
+        targetIndex: "0",
+      }),
+    );
+
+    expect(result.success).toBe(false);
+    expect(result.error).toBe("Invalid target status");
+    expect(mockServerWriteFile).not.toHaveBeenCalled();
+  });
+
   it("rejects without edit permission", async () => {
     mockCheckUserPermission.mockResolvedValue(false);