feat(ov_api): add and delete ownership voucher in onboarding server #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs at least a decent descriptive commit message, a header with "working model" isn't really enough, What does the patch do? From the commit message I can not tell. Also possibly a sign off line (Not sure if we explicitly require them). Also tests? They should probably be in a second commit in the PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let ov_list: [&str; 1] = ["89cb17fd-95e7-4de8-a36a-686926a7f88f"]; | ||
| let delete_ov = client | ||
| .post(format!( | ||
| "http://localhost:{}/management/v1/ownership_voucher/delete", |
Check failure
Code scanning / devskim
Insecure URL
say-paul
changed the title
say-paul
force-pushed
the
ov_api
branch
3 times, most recently
from
c0d3dcc to
89007e7
Compare
|
Added test and fixed the commit message |
ownership voucher management provide easy api to mange fleet of devices ov management provides the below feature: -add ownership voucher to onborading server for easier device onboarding -supported ov formats are cobr and pem. -user can also delete device(s) using guid Signed-off-by: Sayan Paul <[email protected]>
|
Closing this for the time being as it needs work, we'll revisit when we have a more defined requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #132
endpoints:
POST /management/v1/ownership_voucher
POST /management/v1/ownership_voucher/delete