Skip to content

Commit ad546f6

Browse files
committed
fix: Reviewers comment fixed
Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
1 parent d271367 commit ad546f6

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

sdk/python/feast/api/registry/rest/system_metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def _parse_prometheus_text(text: str) -> dict:
6262
if base_name not in metrics:
6363
metrics[base_name] = {"type": current_type, "samples": []}
6464
try:
65-
val = float(value)
65+
val: float | str = float(value)
6666
except ValueError:
6767
val = value
6868
metrics[base_name]["samples"].append(
@@ -100,7 +100,7 @@ def _query_prometheus(path: str, params: dict) -> dict:
100100
headers["Authorization"] = f"Bearer {token}"
101101

102102
ca_bundle = _get_ca_bundle()
103-
verify = ca_bundle if ca_bundle else False
103+
verify: bool | str = ca_bundle if ca_bundle else False
104104

105105
try:
106106
resp = http_requests.get(

sdk/python/feast/infra/offline_stores/offline_store.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,14 @@ def __init__(
7474

7575
def _extract_retrieval_metadata(job: "RetrievalJob") -> tuple:
7676
"""Return ``(feature_view_names, feature_count)`` from a RetrievalJob's metadata."""
77+
from feast.utils import _parse_feature_ref
78+
7779
try:
7880
meta = job.metadata
7981
if meta:
8082
feature_count = len(meta.features)
8183
feature_views = list(
82-
{ref.split(":")[0] for ref in meta.features if ":" in ref}
84+
{_parse_feature_ref(ref)[0] for ref in meta.features if ":" in ref}
8385
)
8486
return feature_views, feature_count
8587
except (NotImplementedError, AttributeError):

0 commit comments

Comments
 (0)