BaseEffectContext: ignore MAX_POSITION if the tween is actively playing (closes #1827)

joshtynjala · joshtynjala · commit 68717a93f258 · 2024-07-31T14:06:09.000-07:00
diff --git a/source/feathers/motion/effectClasses/BaseEffectContext.as b/source/feathers/motion/effectClasses/BaseEffectContext.as
@@ -198,7 +198,10 @@ package feathers.motion.effectClasses
 		 */
 		public function set position(value:Number):void
 		{
-			if(value > MAX_POSITION)
+			// there are some quirks with Starling tweens where we want to avoid
+			// going all of the way to the end, unless the tween is currently
+			// playing
+			if(!this._playing && value > MAX_POSITION)
 			{
 				value = MAX_POSITION;
 			}

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,10 @@ package feathers.motion.effectClasses`
`198`	`198`	`*/`
`199`	`199`	`public function set position(value:Number):void`
`200`	`200`	`{`
`201`		`- if(value > MAX_POSITION)`
	`201`	`+ // there are some quirks with Starling tweens where we want to avoid`
	`202`	`+ // going all of the way to the end, unless the tween is currently`
	`203`	`+ // playing`
	`204`	`+ if(!this._playing && value > MAX_POSITION)`
`202`	`205`	`{`
`203`	`206`	`value = MAX_POSITION;`
`204`	`207`	`}`