program-error!: Make ProgramError compatible with pinocchio (anza-xyz#12)

* turn BorshIoError variants into unit variants

make std optional in solana-program-error

extract solana-pubkey-error crate

add missing feature activation

extract instruction-error crate

remove unnecessary docs target from pubkey-error

make num-traits optional in solana-program-error

missing feature activation in solana-program

move min_specialization to instruction-error

missing feature activation in solana-instruction

remove redundant DecodeError constraint from PrintProgramError

remove unncecessary Error constraint from PrintProgramError

remove num-traits dep and rename the num-traits feature to solana-msg

add missing changes after removing num-traits

make pubkey-error optional

move instruction error codes to program-error and fix pubkey-error import

fmt

move PubkeyError back to solana-pubkey and move ProgramError conversion to solana-pubkey

enable std if solana-msg is enabled

add ToStr trait

post-rebase fixes

fmt toml

* Fix CI, remove solana-instruction where not needed

* Run cargo-sort

---------

Co-authored-by: Jon C <[email protected]>

Author: 2 people

Cargo.lock

@@ -37,6 +37,7 @@ members = [
     "hash",
     "inflation",
     "instruction",
+    "instruction-error",
     "instructions-sysvar",
     "keccak-hasher",
     "keypair",
@@ -244,6 +245,7 @@ solana-hard-forks = { path = "hard-forks", version = "2.2.1", default-features =
 solana-hash = { path = "hash", version = "2.2.1", default-features = false }
 solana-inflation = { path = "inflation", version = "2.2.1" }
 solana-instruction = { path = "instruction", version = "2.3.0", default-features = false }
+solana-instruction-error = { path = "instruction-error", version = "1.0.0" }
 solana-instructions-sysvar = { path = "instructions-sysvar", version = "2.2.1" }
 solana-keccak-hasher = { path = "keccak-hasher", version = "2.2.1" }
 solana-keypair = { path = "keypair", version = "2.2.1" }

Cargo.toml

@@ -15,12 +15,7 @@ all-features = true
 rustdoc-args = ["--cfg=docsrs"]
 
 [features]
-bincode = [
-    "dep:bincode",
-    "dep:solana-sysvar",
-    "solana-instruction/serde",
-    "serde",
-]
+bincode = ["dep:bincode", "dep:solana-sysvar", "serde"]
 dev-context-only-utils = ["bincode", "dep:qualifier_attr"]
 frozen-abi = [
     "dep:solana-frozen-abi",
@@ -45,7 +40,7 @@ solana-account-info = { workspace = true }
 solana-clock = { workspace = true }
 solana-frozen-abi = { workspace = true, optional = true }
 solana-frozen-abi-macro = { workspace = true, optional = true }
-solana-instruction = { workspace = true }
+solana-instruction-error = { workspace = true }
 solana-logger = { workspace = true, optional = true }
 solana-pubkey = { workspace = true }
 solana-sdk-ids = { workspace = true }

account/Cargo.toml

@@ -13,7 +13,7 @@ use solana_sysvar::Sysvar;
 use {
     solana_account_info::{debug_account_data::*, AccountInfo},
     solana_clock::{Epoch, INITIAL_RENT_EPOCH},
-    solana_instruction::error::LamportsError,
+    solana_instruction_error::LamportsError,
     solana_pubkey::Pubkey,
     solana_sdk_ids::{bpf_loader, bpf_loader_deprecated, bpf_loader_upgradeable, loader_v4},
     std::{

account/src/lib.rs

@@ -3,7 +3,7 @@
 use {
     crate::{Account, AccountSharedData},
     bincode::ErrorKind,
-    solana_instruction::error::InstructionError,
+    solana_instruction_error::InstructionError,
     std::cell::Ref,
 };
 

account/src/state_traits.rs

@@ -18,6 +18,7 @@ rustdoc-args = ["--cfg=docsrs"]
 bincode = [
     "dep:bincode",
     "dep:solana-instruction",
+    "dep:solana-instruction-error",
     "serde",
     "solana-instruction/bincode",
 ]
@@ -39,6 +40,7 @@ solana-frozen-abi-macro = { workspace = true, features = [
     "frozen-abi",
 ], optional = true }
 solana-instruction = { workspace = true, features = ["std"], optional = true }
+solana-instruction-error = { workspace = true, optional = true }
 solana-pubkey = { workspace = true }
 solana-sdk-ids = { workspace = true }
 solana-slot-hashes = { workspace = true }

address-lookup-table-interface/Cargo.toml

@@ -3,7 +3,7 @@ use serde_derive::{Deserialize, Serialize};
 #[cfg(feature = "frozen-abi")]
 use solana_frozen_abi_macro::{AbiEnumVisitor, AbiExample};
 #[cfg(feature = "bincode")]
-use solana_instruction::error::InstructionError;
+use solana_instruction_error::InstructionError;
 use {
     crate::error::AddressLookupError,
     solana_clock::Slot,

address-lookup-table-interface/src/state.rs

@@ -15,9 +15,7 @@ targets = ["x86_64-unknown-linux-gnu"]
 [dependencies]
 bincode = { workspace = true }
 serde = { workspace = true }
-solana-instruction = { workspace = true, default-features = false, features = [
-    "std",
-] }
+solana-instruction-error = { workspace = true }
 
 [dev-dependencies]
 solana-system-interface = { workspace = true, features = ["bincode"] }

bincode/Cargo.toml

@@ -2,7 +2,7 @@
 //!
 //! [bincode]: https://docs.rs/bincode
 
-use {bincode::config::Options, solana_instruction::error::InstructionError};
+use {bincode::config::Options, solana_instruction_error::InstructionError};
 
 /// Deserialize with a limit based the maximum amount of data a program can expect to get.
 /// This function should be used in place of direct deserialization to help prevent OOM errors

bincode/src/lib.rs

@@ -14,7 +14,7 @@ targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
 solana-account-info = { workspace = true }
-solana-instruction = { workspace = true }
+solana-instruction = { workspace = true, features = ["std"] }
 solana-program-error = { workspace = true }
 solana-pubkey = { workspace = true }