Deprecate re-exports more loudly (anza-xyz#151)

* Deprecate re-exports more loudly

There are many different crates and types that we would like to remove
from the sdk, but they are still re-exported from solana-sdk and
solana-program. The re-exports have a `#[deprecated(...)]` attribute,
but they aren't flagged to downstream users.

Make the re-export deprecations louder by creating a deprecated module
and re-exporting from in there.

These are the types affected

* `DecodeError`: this trait isn't all that useful, and is set to be
  removed entirely with anza-xyz#104, so deprecate it here

These are the crates to no longer re-export from solana-program because
they will be moved to program-specific repos:

* `address_lookup_table` -> `solana_address_lookup_table_interface`
* `bpf_loader_upgradeable` -> `solana_loader_v3_interface`
* `loader_upgradeable_instruction` ->
  `solana_loader_v3_interface::instruction`
* `loader_v4` -> `solana_loader_v4_interface`
* `loader_v4_instruction` -> `solana_loader_v4_interface::instruction`
* `nonce` -> `solana_nonce`
* `feature` -> `solana_feature_gate_interface`
* `loader_instruction` -> `solana_loader_v2_interface`
* `vote` -> `solana_vote_interface`
* `stake` -> `solana_stake_interface`
* `stake_history` -> `solana_stake_interface::stake_history`
* `system_instruction` -> `solana_system_interface`
* `system_program` -> `solana_sdk_ids::system_program` (not sure about
  this one)

Separately, `solana_message` and `solana_sanitize` are no longer
re-exported. They never quite fit in `solana_program`, and caused more
annoyance than anything else. The re-exports remain in `solana_sdk`.

`solana-decode-error` will be removed entirely, so its deprecation is
louder too.

For `solana-sdk`, there are many types that just don't belong, so stop
re-exporting these:

* `commitment_config` -> `solana_commitment_config`
* `genesis_config` -> `solana_genesis_config`
* `hard_forks` -> `solana_hard_forks`
* `rent_collector` -> `solana_rent_collector`
* `alt_bn128` -> `solana_bn254`
* `client` -> `solana_client_traits`
* `compute_budget` -> `solana_compute_budget_interface`
* `derivation_path` -> `solana_derivation_path`
* `ed25519_instruction` -> `solana_ed25519_program`
* `nonce_account` -> `solana_nonce_account`
* `packet` -> `solana_packet`
* `poh_config` -> `solana_poh_config`
* `quic` -> `solana_quic_definitions`
* `rent_debits` -> `solana_rent_debits`
* `secp256k1_instruction` -> `solana_secp256k1_program`
* `secp256k1_recover` -> `solana_secp256k1_recover`
* `system_transaction` -> `solana_system_transaction`
* `exit` -> `solana_validator_exit`

* Address review feedback

Author: joncinque

Cargo.lock

@@ -21,6 +21,7 @@ use num_traits::FromPrimitive;
 /// [`ProgramError`]: https://docs.rs/solana-program-error/latest/solana_program_error/enum.ProgramError.html
 /// [`ProgramError::Custom`]: https://docs.rs/solana-program-error/latest/solana_program_error/enum.ProgramError.html#variant.Custom
 /// [`ToPrimitive`]: num_traits::ToPrimitive
+#[deprecated(since = "2.3.0", note = "Use `num_traits::FromPrimitive` instead")]
 pub trait DecodeError<E> {
     fn decode_custom_error_to_enum(custom: u32) -> Option<E>
     where
@@ -32,6 +33,7 @@ pub trait DecodeError<E> {
 }
 
 #[cfg(test)]
+#[allow(deprecated)]
 mod tests {
     use {super::*, num_derive::FromPrimitive};
 

decode-error/src/lib.rs

@@ -1,5 +1,5 @@
 /// Precompile errors
-use {core::fmt, solana_decode_error::DecodeError};
+use core::fmt;
 
 /// Precompile errors
 #[derive(Debug, Clone, PartialEq, Eq)]
@@ -69,7 +69,8 @@ impl fmt::Display for PrecompileError {
     }
 }
 
-impl<T> DecodeError<T> for PrecompileError {
+#[allow(deprecated)]
+impl<T> solana_decode_error::DecodeError<T> for PrecompileError {
     fn type_of() -> &'static str {
         "PrecompileError"
     }

precompile-error/src/lib.rs

@@ -9,7 +9,6 @@ use serde_derive::{Deserialize, Serialize};
 use {
     core::fmt,
     num_traits::FromPrimitive,
-    solana_decode_error::DecodeError,
     solana_instruction::error::{
         InstructionError, ACCOUNT_ALREADY_INITIALIZED, ACCOUNT_BORROW_FAILED,
         ACCOUNT_DATA_TOO_SMALL, ACCOUNT_NOT_RENT_EXEMPT, ARITHMETIC_OVERFLOW, BORSH_IO_ERROR,
@@ -126,17 +125,26 @@ impl fmt::Display for ProgramError {
     since = "2.2.2",
     note = "Use `ToStr` instead with `solana_msg::msg!` or any other logging"
 )]
+#[allow(deprecated)]
 pub trait PrintProgramError {
     fn print<E>(&self)
     where
-        E: 'static + std::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive;
+        E: 'static
+            + std::error::Error
+            + solana_decode_error::DecodeError<E>
+            + PrintProgramError
+            + FromPrimitive;
 }
 
 #[allow(deprecated)]
 impl PrintProgramError for ProgramError {
     fn print<E>(&self)
     where
-        E: 'static + std::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive,
+        E: 'static
+            + std::error::Error
+            + solana_decode_error::DecodeError<E>
+            + PrintProgramError
+            + FromPrimitive,
     {
         match self {
             Self::Custom(error) => {

program-error/src/lib.rs

@@ -1,6 +1,9 @@
-#[deprecated(
-    since = "2.2.0",
-    note = "Use solana-address-lookup-table interface instead"
+#![deprecated(
+    since = "2.3.0",
+    note = "Use solana-address-lookup-table-interface and solana-message instead"
 )]
-pub use solana_address_lookup_table_interface::{error, instruction, program, state};
-pub use solana_message::AddressLookupTableAccount;
+
+pub use {
+    solana_address_lookup_table_interface::{error, instruction, program, state},
+    solana_message::AddressLookupTableAccount,
+};

program/src/address_lookup_table.rs

@@ -1,4 +1,5 @@
-#[deprecated(since = "2.2.0", note = "Use solana-loader-v3-interface instead")]
+#![deprecated(since = "2.3.0", note = "Use solana-loader-v3-interface instead")]
+
 #[allow(deprecated)]
 pub use solana_loader_v3_interface::{
     get_program_data_address,

program/src/bpf_loader_upgradeable.rs

@@ -483,25 +483,29 @@ pub mod hash;
 pub mod incinerator;
 pub mod instruction;
 pub mod lamports;
+#[deprecated(
+    since = "2.3.0",
+    note = "Use solana_loader_v3_interface::instruction instead"
+)]
 pub mod loader_upgradeable_instruction {
-    #[deprecated(
-        since = "2.2.0",
-        note = "Use solana_loader_v3_interface::instruction instead"
-    )]
     pub use solana_loader_v3_interface::instruction::UpgradeableLoaderInstruction;
 }
 pub mod loader_v4;
+#[deprecated(
+    since = "2.3.0",
+    note = "Use solana_loader_v4_interface::instruction instead"
+)]
 pub mod loader_v4_instruction {
-    #[deprecated(
-        since = "2.2.0",
-        note = "Use solana_loader_v4_interface::instruction instead"
-    )]
     pub use solana_loader_v4_interface::instruction::LoaderV4Instruction;
 }
 pub mod log;
 pub mod nonce;
 pub mod program;
 pub mod program_error;
+#[deprecated(
+    since = "2.3.0",
+    note = "Use `solana_bincode::limited_deserialize` instead"
+)]
 pub mod program_utils;
 pub mod secp256k1_program;
 pub mod slot_hashes;
@@ -530,29 +534,37 @@ pub use solana_borsh::v1 as borsh1;
 #[deprecated(since = "2.1.0", note = "Use `solana-epoch-rewards` crate instead")]
 pub use solana_epoch_rewards as epoch_rewards;
 #[deprecated(
-    since = "2.2.0",
+    since = "2.3.0",
     note = "Use `solana-feature-gate-interface` crate instead"
 )]
-pub use solana_feature_gate_interface as feature;
+pub mod feature {
+    pub use solana_feature_gate_interface::*;
+}
 #[deprecated(since = "2.1.0", note = "Use `solana-fee-calculator` crate instead")]
 pub use solana_fee_calculator as fee_calculator;
 #[deprecated(since = "2.2.0", note = "Use `solana-keccak-hasher` crate instead")]
 pub use solana_keccak_hasher as keccak;
 #[deprecated(since = "2.1.0", note = "Use `solana-last-restart-slot` crate instead")]
 pub use solana_last_restart_slot as last_restart_slot;
 #[deprecated(
-    since = "2.2.0",
+    since = "2.3.0",
     note = "Use `solana-loader-v2-interface` crate instead"
 )]
-pub use solana_loader_v2_interface as loader_instruction;
-#[deprecated(since = "2.2.0", note = "Use `solana-message` crate instead")]
-pub use solana_message as message;
+pub mod loader_instruction {
+    pub use solana_loader_v2_interface::*;
+}
+#[deprecated(since = "2.3.0", note = "Use `solana-message` crate instead")]
+pub mod message {
+    pub use solana_message::*;
+}
 #[deprecated(since = "2.1.0", note = "Use `solana-program-memory` crate instead")]
 pub use solana_program_memory as program_memory;
 #[deprecated(since = "2.1.0", note = "Use `solana-program-pack` crate instead")]
 pub use solana_program_pack as program_pack;
-#[deprecated(since = "2.1.0", note = "Use `solana-sanitize` crate instead")]
-pub use solana_sanitize as sanitize;
+#[deprecated(since = "2.3.0", note = "Use `solana-sanitize` crate instead")]
+pub mod sanitize {
+    pub use solana_sanitize::*;
+}
 #[deprecated(since = "2.1.0", note = "Use `solana-secp256k1-recover` crate instead")]
 pub use solana_secp256k1_recover as secp256k1_recover;
 #[deprecated(since = "2.1.0", note = "Use `solana-serde-varint` crate instead")]
@@ -565,8 +577,10 @@ pub use solana_short_vec as short_vec;
 pub use solana_stable_layout as stable_layout;
 #[cfg(not(target_os = "solana"))]
 pub use solana_sysvar::program_stubs;
-#[deprecated(since = "2.2.0", note = "Use `solana-vote-interface` crate instead")]
-pub use solana_vote_interface as vote;
+#[deprecated(since = "2.3.0", note = "Use `solana-vote-interface` crate instead")]
+pub mod vote {
+    pub use solana_vote_interface::*;
+}
 #[cfg(target_arch = "wasm32")]
 pub use wasm_bindgen::prelude::wasm_bindgen;
 pub use {
@@ -632,8 +646,10 @@ pub mod sdk_ids {
     }
 }
 
-#[deprecated(since = "2.1.0", note = "Use `solana-decode-error` crate instead")]
-pub use solana_decode_error as decode_error;
+#[deprecated(since = "2.3.0", note = "Use `num_traits::FromPrimitive` instead")]
+pub mod decode_error {
+    pub use solana_decode_error::*;
+}
 pub use solana_pubkey::{declare_deprecated_id, declare_id, pubkey};
 #[deprecated(since = "2.1.0", note = "Use `solana-sysvar-id` crate instead")]
 pub use solana_sysvar_id::{declare_deprecated_sysvar_id, declare_sysvar_id};

program/src/lib.rs

@@ -1,14 +1,14 @@
-#[deprecated(since = "2.2.0", note = "Use solana-loader-v4-interface instead")]
-pub use solana_loader_v4_interface::{
-    instruction::{
-        create_buffer, deploy, deploy_from_source, finalize, is_deploy_instruction,
-        is_finalize_instruction, is_retract_instruction, is_set_program_length_instruction,
-        is_set_program_length_instruction as is_truncate_instruction,
-        is_transfer_authority_instruction, is_write_instruction, retract,
-        set_program_length as truncate, set_program_length as truncate_uninitialized,
-        set_program_length, transfer_authority, write,
+#![deprecated(since = "2.3.0", note = "Use solana-loader-v4-interface instead")]
+pub use {
+    solana_loader_v4_interface::{
+        instruction::{
+            create_buffer, deploy, deploy_from_source, finalize, is_deploy_instruction,
+            is_finalize_instruction, is_retract_instruction, is_set_program_length_instruction,
+            is_transfer_authority_instruction, is_write_instruction, retract,
+            set_program_length as truncate, transfer_authority, write,
+        },
+        state::{LoaderV4State, LoaderV4Status},
+        DEPLOYMENT_COOLDOWN_IN_SLOTS,
     },
-    state::{LoaderV4State, LoaderV4Status},
-    DEPLOYMENT_COOLDOWN_IN_SLOTS,
+    solana_sdk_ids::loader_v4::{check_id, id, ID},
 };
-pub use solana_sdk_ids::loader_v4::{check_id, id, ID};

program/src/loader_v4.rs

@@ -1,3 +1,5 @@
+#![deprecated(since = "2.3.0", note = "Use solana_nonce instead")]
+
 pub use solana_nonce::{state::State, NONCED_TX_MARKER_IX_INDEX};
 pub mod state {
     pub use solana_nonce::{

program/src/nonce.rs

@@ -1,10 +1,9 @@
-#[deprecated(since = "2.2.0", note = "Use solana-stake-interface instead")]
+#![deprecated(since = "2.3.0", note = "Use solana-stake-interface instead")]
 pub use solana_stake_interface::{
     config, stake_flags, state, tools, MINIMUM_DELINQUENT_EPOCHS_FOR_DEACTIVATION,
 };
 
 pub mod instruction {
-    #[deprecated(since = "2.2.0", note = "Use solana-stake-interface instead")]
     pub use solana_stake_interface::{error::StakeError, instruction::*};
 }