fix: avoid_public_bloc_methods for getters

[aggeloskoutanis]

Description
Hello everyone. First of all, thanks for creating the bloc linter. I am delighted with it. I just wanted to bring something up for discussion that I think is mistakenly flagged by the lint rule avoid_public_bloc_methods.
In my bloc, I have a public getter which I use as a utility getter in order to access a bool variable. This bool variable is declared and initialized inside my bloc, and it's static.
Now, this getter is flagged by the avoid_public_bloc_methods rule, which I understand why, but I think it shouldn't be. My understanding is that this rule exists so we won't use a public method to alter the state inside the bloc, and instead use the events of the bloc to do this.

The getter is not used to change the state, so I find it a bit irrelevant to flag this with avoid_public_bloc_methods.

Steps To Reproduce

1. Create a getter inside a bloc (example: bool get hello => false;)

Expected Behavior
Do not mark methods/getters that don't change the state with the rule avoid_public_bloc_methods.

[felangel]

Hi @aggeloskoutanis 👋
Thanks for opening an issue!

Can you please provide a bit more context regarding what the specific getter is used for in your case? This is currently working as intended but happy to adjust if it makes sense. Thanks!

[aggeloskoutanis]

Thanks for the fast answer, Felix. Of course, I can provide context.

In my HydratedBloc, I have a static variable which is either initialized inside the overridden fromJson, or it's initialized after by fetching some data from the server.

This variable is a feature flag. And I want it to be initialized only once per user session.

Some pseudocode

1. I declare it as static bool _featureFlag inside the bloc

2

  AppConfigurationState? fromJson(Map<String, dynamic> json) {
    final state = AppConfigurationState(
   \\ Creating the state
    );

    // Set the static initial EDORS flag from hydrated appConfig
    if (_featureFlag == null && state.appConfig != null) {
      _featureFlag = state.appConfig!.featureFlag;
    }

    return state;
  }

 Future<void> _fetchAppConfiguration() async {
     final data = api.fetchData();

 
      _featureFlag ??= data.appConfig.featureFlag;
}

4. I use this getter to access it bool get featureFlag => _featureFlag ?? false;

Probably, I could have it as a state variable as well, but since it's a feature flag variable and it's going to be deprecated in the future, I was thinking of having it as static, so it's not connected directly with the state of the bloc.