fix: hook stuck when installed via git

[Joschiller]

Description

We have the following scenario:

• Our brick contains a pre-hook that prints out some metadata (e.g. project directory) and injects it into the template files of the brick.
• When installing the brick locally via a file-path, running the brick works fine (console output is visible and files are generated).
• When installing the brick from a git repository, running the brick leads to a stuck console. Not even the log output of the hook is visible.

If we install any other brick without any hook via git, these bricks work just fine.

Steps To Reproduce

1. Create a brick with a pre hook and push it to a git repository
2. Install the brick via the git-url in another project
3. Run the brick

Expected Behavior

The pre hook should be executed, even if the corresponding brick was installed via git.

Screenshots

none

Additional Context

Contents of our pre-hook. Purpose: retrieving the package name from the pubspec.yaml.

import 'dart:io';

import 'package:mason/mason.dart';
import 'package:yaml/yaml.dart';

const pubspecYamlName = 'pubspec.yaml';
Future<File?> _getPackageYaml(HookContext context) async {
  var directory = Directory.current;

  var depth = 5;
  do {
    try {
      context.logger.info(directory.path);
      final yaml = (await directory
          .list()
          .firstWhere((file) => file.path.endsWith(pubspecYamlName)));
      return File(yaml.absolute.path);
    } catch (_) {
      directory = directory.parent;
      depth--;
    }
  } while (depth > 0);
  return null;
}

void run(HookContext context) async {
  final yamlFile = await _getPackageYaml(context);
  if (yamlFile != null) {
    context.logger.info('Füge $pubspecYamlName-Inhalt unter "package" ein.');
    final data = loadYaml(await yamlFile.readAsString());
    context.vars.putIfAbsent('package', () => data);
  }
}

I am quite sure, that the combination of hook + git integration is the reason for the problem as all our bricks work just fine if just one of those are used.

Environment: Windows 10, Flutter 3.32.2

[dhohmann]

Addition: The hook works on MacOS. Same project, same structure, no changes.

[felangel]

Hi @dhohmann 👋
Thanks for opening an issue!

Can you share the full output of running the brick? Are there any errors being reported? Also how are you running the brick (e.g powershell, wsl, git bash, etc)?

Can you also run mason --version and share the output?

[Joschiller]

Hi,

usually we use the git bash for running our commands - but using powershell yields the same results.

---

Scneario 1: Brick installed locally:

bricks:
  dao:
    path: ../../app-bricks/dao

mason make dao runs normally

---

Scenario 2: Brick installed via git:

bricks:
  dao:
    git:
      url: some-local-git-url/app-bricks.git
      path: dao

mason make dao only asks for the user input - but does not generate any further output

[felangel]

Hi,

usually we use the git bash for running our commands - but using powershell yields the same results.

Scneario 1: Brick installed locally:

bricks:
dao:
path: ../../app-bricks/dao
mason make dao runs normally

Scenario 2: Brick installed via git:

bricks:
dao:
git:
url: some-local-git-url/app-bricks.git
path: dao
mason make dao only asks for the user input - but does not generate any further output

Hmm does this only happen on windows? Might be due to your windows installation not having longer paths enabled.

[Joschiller]

Thanks for the advice. We have tried to change the value but this did not change the behavior.

Do you have any other ideas on how to fix this?

Is there a way to view more log details so we could analyze the issue?

[felangel]

Thanks for the advice. We have tried to change the value but this did not change the behavior.

Do you have any other ideas on how to fix this?

Is there a way to view more log details so we could analyze the issue?

Are you able to make a minimal reproduction sample? Should be easy to diagnose once I’m able to reproduce the issue. Does this only occur on windows?

[Joschiller]

I've created an example repository here: https://github.com/Joschiller/mason-issue-1573-example

In our app repository I then only have a mason.yaml with the dependency listed in the readme of the example project.

All further information can be found in the readme.

[shaheer-fusion]

having the same problem