refactor: Reuse code

felix-andreas · felix-andreas · commit 24c560244c91 · 2025-07-17T02:20:14.000+02:00
diff --git a/crates/roughly/src/definition.rs b/crates/roughly/src/definition.rs
@@ -35,8 +35,7 @@ pub fn goto(
         )));
     }
 
-    let is_local_scope = std::iter::successors(Some(start), |node| node.parent())
-        .any(|node| node.kind_id() == kind::FUNCTION_DEFINITION);
+    let is_local_scope = tree::find_containing_function(start).is_some();
 
     let globals = symbols_map.filter_map(
         |path, symbols| {

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,7 @@ pub fn goto(`
`35`	`35`	`)));`
`36`	`36`	`}`
`37`	`37`
`38`		`- let is_local_scope = std::iter::successors(Some(start), \|node\| node.parent())`
`39`		`- .any(\|node\| node.kind_id() == kind::FUNCTION_DEFINITION);`
	`38`	`+ let is_local_scope = tree::find_containing_function(start).is_some();`
`40`	`39`
`41`	`40`	`let globals = symbols_map.filter_map(`
`42`	`41`	`\|path, symbols\| {`