feat: Implement goto definition (#39)

Author: felix-andreas

crates/roughly/src/cli.rs

@@ -474,32 +474,31 @@ pub fn ast(path: &Path) -> Result<(), DebugError> {
 
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct ExperimentalFeatures {
+    pub goto_definition: bool,
     pub range_formatting: bool,
     pub unused: bool,
 }
 
 impl ExperimentalFeatures {
     pub fn parse(flags: &[impl AsRef<str>]) -> Self {
-        let mut unused = false;
-        let mut range_formatting = false;
+        let mut features = ExperimentalFeatures::default();
 
         for flag in flags {
             match flag.as_ref() {
                 "all" => {
-                    unused = true;
-                    range_formatting = true;
+                    features.unused = true;
+                    features.range_formatting = true;
+                    features.goto_definition = true;
                 }
-                "range_formatting" => range_formatting = true,
-                "unused" => unused = true,
+                "range_formatting" => features.range_formatting = true,
+                "goto_definition" => features.goto_definition = true,
+                "unused" => features.unused = true,
                 unknown => {
                     warn(&format!("unknown experimental feature: {unknown}"));
                 }
             }
         }
 
-        Self {
-            unused,
-            range_formatting,
-        }
+        features
     }
 }

crates/roughly/src/completions.rs

@@ -1,11 +1,13 @@
 use {
     crate::{
         index::SymbolsMap,
-        lsp_types::{CompletionItem, CompletionItemKind, CompletionResponse, Position, SymbolKind},
-        tree::{self, kind},
+        lsp_types::{
+            CompletionItem, CompletionItemKind, CompletionItemLabelDetails, CompletionResponse,
+            Position, SymbolKind,
+        },
+        tree::{self, field, kind},
         utils,
     },
-    async_lsp::lsp_types::CompletionItemLabelDetails,
     ropey::Rope,
     tree_sitter::{Node, Point, Query, StreamingIterator},
 };
@@ -130,10 +132,7 @@ pub fn get(
 
     let local_symbols: Vec<CompletionItem> =
         {
-            let point = Point {
-                row: position.line as usize,
-                column: position.character as usize,
-            };
+            let point = Point::new(position.line as usize, position.character as usize);
             tree.root_node()
                 .descendant_for_point_range(point, point)
                 .map(|node| {
@@ -143,12 +142,12 @@ pub fn get(
                         .flat_map(|node| {
                             let mut items = Vec::new();
 
-                            if let Some(parameters) = node.child_by_field_name("parameters") {
+                            if let Some(parameters) = node.child_by_field_id(field::PARAMETERS) {
                                 items.extend(
                                     parameters
                                         .children_by_field_name("parameter", &mut parameters.walk())
                                         .filter_map(|parameter| {
-                                            parameter.child_by_field_name("name").map(|name| {
+                                            parameter.child_by_field_id(field::NAME).map(|name| {
                                                 rope.byte_slice(name.byte_range()).to_string()
                                             })
                                         })
@@ -165,7 +164,7 @@ pub fn get(
                                 );
                             }
 
-                            if let Some(body) = node.child_by_field_name("body") {
+                            if let Some(body) = node.child_by_field_id(field::BODY) {
                                 items.extend(locals_completion(body, rope).into_iter().filter(
                                     |item| utils::starts_with_lowercase(&item.label, &query),
                                 ));