chore: Stabilize goto definition

Author: felix-andreas

README.md

@@ -32,7 +32,7 @@ Roughly aims to support the following language server features (some are experim
   - Index global variables, S4 and R6 classes/methods
   - Search current document - <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>O</kbd> *in VS Code*
   - Search global workspace - <kbd>Ctrl</kbd> + <kbd>T</kbd> *in VS Code*
-  - Go to definition *(🧪 experimental)*
+  - Go to definition
   - Find all references *(🧪 experimental)*
 
 - **Diagnostics**
@@ -134,7 +134,7 @@ You can customize the Roughly extension in VS Code through the following setting
   // Pass custom arguments; defaults to ["server"]
   "roughly.args": ["server", "--verbose"],
   // Enable experimental features
-  "roughly.experimentalFeatures": ["goto_definition", "range_formatting"],
+  "roughly.experimentalFeatures": ["rename", "range_formatting"],
 }
 ```
 
@@ -177,7 +177,6 @@ Roughly includes several experimental features that can be enabled in the VS Cod
 | Name               | Description                      |
 | ------------------ | -------------------------------- |
 | `all`              | Enable all experimental features |
-| `goto_definition`  | Jump to symbol definitions       |
 | `goto_references`  | Find all references to a symbol  |
 | `range_formatting` | Format selected code ranges      |
 | `rename`           | Rename symbols                   |

crates/roughly/src/cli.rs

@@ -488,19 +488,22 @@ pub fn parse_experimental_flags(flags: &[impl AsRef<str>]) -> ExperimentalFeatur
     for flag in flags.iter().flat_map(|flag| flag.as_ref().split(' ')) {
         match flag {
             "all" => {
-                features.goto_definition = true;
                 features.goto_references = true;
                 features.range_formatting = true;
                 features.rename = true;
                 features.unused = true;
             }
-            "goto_definition" => features.goto_definition = true,
             "goto_references" => features.goto_references = true,
             "range_formatting" => features.range_formatting = true,
             "rename" => features.rename = true,
             "unused" => features.unused = true,
+            "goto_definition" => {
+                warn(&format!(
+                    "The '{flag}' flag has been stabilized. You can remove it."
+                ));
+            }
             unknown => {
-                warn(&format!("unknown experimental feature: {unknown}"));
+                warn(&format!("unknown experimental feature: '{unknown}'"));
             }
         }
     }

crates/roughly/src/config.rs

@@ -90,7 +90,6 @@ impl ConfigToml {
 
 #[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub struct ExperimentalFeatures {
-    pub goto_definition: bool,
     pub goto_references: bool,
     pub range_formatting: bool,
     pub rename: bool,

crates/roughly/src/server.rs

@@ -149,7 +149,7 @@ impl LanguageServer for ServerState {
                     trigger_characters: Some(vec!["$".into(), "@".into(), ":".into()]),
                     ..Default::default()
                 }),
-                definition_provider: Some(OneOf::Left(self.experimental_features.goto_definition)),
+                definition_provider: Some(OneOf::Left(true)),
                 document_formatting_provider: Some(OneOf::Left(true)),
                 document_range_formatting_provider: Some(OneOf::Left(
                     self.experimental_features.range_formatting,

docs/src/content/docs/language-server.mdx

@@ -27,7 +27,7 @@ Roughly aims to support the following language server features (some are experim
   - Index global variables, S4 and R6 classes/methods
   - Search current document - <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>O</kbd> *in VS Code*
   - Search global workspace - <kbd>Ctrl</kbd> + <kbd>T</kbd> *in VS Code*
-  - Go to definition *(🧪 experimental)*
+  - Go to definition
   - Find all references *(🧪 experimental)*
 
 - **Diagnostics**
@@ -105,7 +105,7 @@ You can customize the Roughly extension in VS Code through the following setting
   // Pass custom arguments; defaults to ["server"]
   "roughly.args": ["server", "--verbose"],
   // Enable experimental features
-  "roughly.experimentalFeatures": ["goto_definition", "range_formatting"],
+  "roughly.experimentalFeatures": ["rename", "range_formatting"],
 }
 ```
 

editors/code/README.md

@@ -17,7 +17,7 @@ Roughly aims to support the following language server features (some are experim
   - Index global variables, S4 and R6 classes/methods
   - Search current document - <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>O</kbd> *in VS Code*
   - Search global workspace - <kbd>Ctrl</kbd> + <kbd>T</kbd> *in VS Code*
-  - Go to definition *(🧪 experimental)*
+  - Go to definition
   - Find all references *(🧪 experimental)*
 
 - **Diagnostics**
@@ -50,7 +50,7 @@ You can customize the Roughly extension in VS Code through the following setting
   // Pass custom arguments; defaults to ["server"]
   "roughly.args": ["server", "--verbose"],
   // Enable experimental features
-  "roughly.experimentalFeatures": ["goto_definition", "range_formatting"],
+  "roughly.experimentalFeatures": ["rename", "range_formatting"],
 }
 ```