improved tox solc checker to be able to find locally installed version in path and use that one if it is 0.8.24 instead of downloading it which does not work on arm

Author: felix314159

tox.ini

@@ -79,19 +79,52 @@ allowlist_externals =
     chmod
     test
     solc
+    grep
 commands_pre =
     # Create bin directory
     mkdir -p {envdir}/bin
-    # Download platform-specific solc
-    sh -c 'if [ "$(uname)" = "Darwin" ]; then \
+    # if solc 0.8.24 exists already we are done, otherwise download it and verify version equals 0.8.24 (will fail on linux-arm64) 
+    sh -c 'echo "Checking for system solc..."; \
+        if command -v solc >/dev/null 2>&1; then \
+            SYSTEM_SOLC=$(command -v solc); \
+            echo "Found solc at $SYSTEM_SOLC"; \
+            VERSION_OUTPUT=$("$SYSTEM_SOLC" --version 2>&1); \
+            echo "Found solc version:"; \
+            echo "$VERSION_OUTPUT"; \
+            if echo "$VERSION_OUTPUT" | grep -q "Version: 0\.8\.24"; then \
+                echo "System solc is correct version, copying to tox env..."; \
+                mkdir -p {envdir}/bin; \
+                cp "$SYSTEM_SOLC" {envdir}/bin/solc; \
+                exit 0; \
+            else \
+                echo "This is not the correct version, expected 0.8.24."; \
+            fi; \
+        fi; \
+        for dir in "{envdir}/bin" "{envdir}/local/bin"; do \
+            if [ -x "$dir/solc" ]; then \
+                echo "Found solc at $dir/solc"; \
+                VERSION_OUTPUT=$("$dir/solc" --version 2>&1); \
+                echo "Found solc version:"; \
+                echo "$VERSION_OUTPUT"; \
+                if echo "$VERSION_OUTPUT" | grep -q "Version: 0\.8\.24"; then \
+                    exit 0; \
+                else \
+                    echo "This is not the correct version, expected 0.8.24."; \
+                fi; \
+            fi; \
+        done; \
+        echo "Downloading solc 0.8.24..."; \
+        mkdir -p {envdir}/bin; \
+        if [ "$(uname)" = "Darwin" ]; then \
             curl -L -o {envdir}/bin/solc https://github.com/ethereum/solidity/releases/download/v0.8.24/solc-macos; \
         else \
             curl -L -o {envdir}/bin/solc https://github.com/ethereum/solidity/releases/download/v0.8.24/solc-static-linux; \
-        fi;'
-    # Make it executable
-    chmod +x {envdir}/bin/solc
-    # Verify it works
-    solc --version
+        fi; \
+        chmod +x {envdir}/bin/solc; \
+        echo "Downloaded solc to {envdir}/bin/solc"; \
+        echo "Verifying installation..."; \
+        {envdir}/bin/solc --version'
+        
 commands =
     pytest -c ./pytest-framework.ini -n auto -m "not run_in_serial"
     pytest -c ./pytest-framework.ini -m run_in_serial