Skip to content

Commit 7af226c

Browse files
committed
fix(fill --collect-only): allow running fill --collect-only even when fixtures folder does not exist
1 parent 1115574 commit 7af226c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Test fixtures for use by clients are available for each release on the [Github r
1515
- ✨ Blockchain and Blockchain-Engine tests that were generated from a state test now have `blockchain_test_from_state_test` or `blockchain_test_engine_from_state_test` as part of their test IDs ([#1220](https://github.com/ethereum/execution-spec-tests/pull/1220)).
1616
- 🔀 Refactor `ethereum_test_fixtures` and `ethereum_clis` to create `FixtureConsumer` and `FixtureConsumerTool` classes which abstract away the consumption process used by `consume direct` ([#935](https://github.com/ethereum/execution-spec-tests/pull/935)).
1717
- ✨ Allow `consume direct --collect-only` without specifying a fixture consumer binary on the command-line ([#1237](https://github.com/ethereum/execution-spec-tests/pull/1237)).
18+
- ✨ Allow `fill --collect-only` without the need for existence of the folder `./fixtures'
1819
- ✨ Report the (resolved) fixture tarball URL and local fixture cache directory when `consume`'s `--input` flag is a release spec or URL [#1239](https://github.com/ethereum/execution-spec-tests/pull/1239).
1920
- ✨ EOF Container validation tests (`eof_test`) now generate container deployment state tests, by wrapping the EOF container in an init-container and sending a deploy transaction ([#783](https://github.com/ethereum/execution-spec-tests/pull/783), [#1233](https://github.com/ethereum/execution-spec-tests/pull/1233)).
2021
- ✨ Use regexes for Hive's `--sim.limit` argument and don't use xdist if `--sim.parallelism==1` in the `eest/consume-rlp` and `eest/consume-rlp` simulators ([#1220](https://github.com/ethereum/execution-spec-tests/pull/1220)).

src/pytest_plugins/filler/filler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,8 @@ def pytest_sessionfinish(session: pytest.Session, exitstatus: int):
793793
return
794794

795795
output: Path = session.config.getoption("output")
796-
if is_output_stdout(output):
796+
# When using --collect-only it should not matter whether fixtures folder exists or not
797+
if is_output_stdout(output) or session.config.option.collectonly:
797798
return
798799

799800
output_dir = strip_output_tarball_suffix(output)

0 commit comments

Comments
 (0)