Address full-day start time review feedback

Author: felixgollnhuber

src/app/api/events/[slug]/ics/route.test.ts

@@ -110,7 +110,7 @@ describe("GET /api/events/[slug]/ics", () => {
         eventType: "full_day",
         timezone: "Europe/Vienna",
         fullDayStartMinutes: 18 * 60,
-        meetingDurationMinutes: 60,
+        meetingDurationMinutes: 180,
         status: "CLOSED",
         finalizedSlot: {
           slotStart: "2026-04-01T22:00:00.000Z",

src/app/api/events/[slug]/ics/route.ts

@@ -1,7 +1,7 @@
 import { NextResponse } from "next/server";
 
 import { getPublicEventSnapshot } from "@/lib/event-service";
-import { buildSlotStart } from "@/lib/availability";
+import { buildTimedFullDaySlotWindow } from "@/lib/availability";
 import { createI18n, getLocaleFromRequest } from "@/lib/i18n/server";
 import { buildEventCalendarFile } from "@/lib/ics";
 import { PUBLIC_NO_STORE_HEADERS, mergeHeaders } from "@/lib/security";
@@ -34,18 +34,13 @@ export async function GET(request: Request, { params }: Context) {
     event.snapshot.eventType === "full_day" &&
     event.snapshot.fullDayStartMinutes !== null &&
     event.snapshot.fullDayStartMinutes !== undefined;
-  const slotStart = isTimedFullDayEvent
-    ? buildSlotStart(
-        event.snapshot.finalizedSlot.dateKey,
-        event.snapshot.fullDayStartMinutes ?? 0,
-        event.snapshot.timezone,
-      )
-    : event.snapshot.finalizedSlot.slotStart;
-  const slotEnd = isTimedFullDayEvent
-    ? new Date(
-        new Date(slotStart).getTime() + event.snapshot.meetingDurationMinutes * 60 * 1000,
-      ).toISOString()
-    : event.snapshot.finalizedSlot.slotEnd;
+  const timedFullDaySlotWindow = isTimedFullDayEvent
+    ? buildTimedFullDaySlotWindow({
+        dateKey: event.snapshot.finalizedSlot.dateKey,
+        fullDayStartMinutes: event.snapshot.fullDayStartMinutes ?? 0,
+        timezone: event.snapshot.timezone,
+      })
+    : null;
 
   const body = buildEventCalendarFile({
     slug: event.snapshot.slug,
@@ -54,8 +49,8 @@ export async function GET(request: Request, { params }: Context) {
     isOnlineMeeting: event.snapshot.isOnlineMeeting,
     meetingLink: event.snapshot.meetingLink,
     timezone: event.snapshot.timezone,
-    slotStart,
-    slotEnd,
+    slotStart: timedFullDaySlotWindow?.slotStart ?? event.snapshot.finalizedSlot.slotStart,
+    slotEnd: timedFullDaySlotWindow?.slotEnd ?? event.snapshot.finalizedSlot.slotEnd,
     allDayDateKey:
       event.snapshot.eventType === "full_day" && !isTimedFullDayEvent
         ? event.snapshot.finalizedSlot.dateKey

src/components/full-day-availability.tsx

@@ -27,7 +27,8 @@ import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/com
 import { SegmentedControl, SegmentedControlItem } from "@/components/ui/segmented-control";
 import { Sheet, SheetContent, SheetHeader, SheetTitle, SheetTrigger } from "@/components/ui/sheet";
 import type { BoardMode } from "@/components/event-heatmap";
-import { minutesToLabel } from "@/lib/availability";
+import { formatFullDayDateLabel, minutesToLabel } from "@/lib/availability";
+import type { AppLocale } from "@/lib/i18n/locale";
 import { useI18n } from "@/lib/i18n/context";
 import type { PublicEventSnapshot, SnapshotParticipant, SnapshotSlot } from "@/lib/types";
 import { cn } from "@/lib/utils";
@@ -181,12 +182,13 @@ function getDisabledDayStyle(): CSSProperties {
   };
 }
 
-function getDayLabel(snapshot: PublicEventSnapshot, slot: SnapshotSlot) {
-  const dateLabel = snapshot.dates.find((date) => date.dateKey === slot.dateKey)?.label ?? slot.dateKey;
-
-  return snapshot.fullDayStartMinutes === null || snapshot.fullDayStartMinutes === undefined
-    ? dateLabel
-    : `${dateLabel} · ${minutesToLabel(snapshot.fullDayStartMinutes)}`;
+function getDayLabel(snapshot: PublicEventSnapshot, slot: SnapshotSlot, locale: AppLocale) {
+  return formatFullDayDateLabel({
+    dateKey: slot.dateKey,
+    fullDayStartMinutes: snapshot.fullDayStartMinutes,
+    timezone: snapshot.timezone,
+    locale,
+  });
 }
 
 function getDayElementFromPoint(clientX: number, clientY: number) {
@@ -273,7 +275,7 @@ export function FullDayAvailability({
   onActiveParticipantChange,
   description,
 }: FullDayAvailabilityProps) {
-  const { messages, format, plural, intlLocale } = useI18n();
+  const { messages, format, plural, intlLocale, locale } = useI18n();
   const [activeSlotStart, setActiveSlotStart] = useState<string | null>(null);
   const [internalActiveParticipantId, setInternalActiveParticipantId] = useState<string | null>(
     null,
@@ -348,7 +350,7 @@ export function FullDayAvailability({
   const activeSlotDetails = activeSlot
     ? {
         slot: activeSlot,
-        dateLabel: getDayLabel(snapshot, activeSlot),
+        dateLabel: getDayLabel(snapshot, activeSlot, locale),
         availableParticipants: snapshot.participants.filter((participant) =>
           activeSlot.participantIds.includes(participant.id),
         ),
@@ -377,7 +379,7 @@ export function FullDayAvailability({
   }, []);
 
   function getAvailabilityTitle(slot: SnapshotSlot) {
-    const dateLabel = getDayLabel(snapshot, slot);
+    const dateLabel = getDayLabel(snapshot, slot, locale);
     const availableNames = slot.participantIds
       .map((participantId) => participantNamesById.get(participantId))
       .filter(Boolean) as string[];

src/components/ui/segmented-control.tsx

@@ -22,11 +22,12 @@ export function SegmentedControlItem({
   active,
   className,
   ...props
-}: React.ButtonHTMLAttributes<HTMLButtonElement> & {
+}: Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "aria-pressed" | "type"> & {
   active?: boolean;
 }) {
   return (
     <button
+      {...props}
       type="button"
       data-slot="segmented-control-item"
       data-active={active ? "true" : undefined}
@@ -37,7 +38,6 @@ export function SegmentedControlItem({
         className,
       )}
       aria-pressed={active}
-      {...props}
     />
   );
 }

src/lib/availability.test.ts

@@ -217,7 +217,7 @@ describe("availability helpers", () => {
       fullDayStartMinutes: 18 * 60,
       status: "OPEN",
       slotMinutes: 30,
-      meetingDurationMinutes: 60,
+      meetingDurationMinutes: 180,
       dayStartMinutes: 9 * 60,
       dayEndMinutes: 11 * 60,
       dates: ["2026-04-10"],

src/lib/availability.ts

@@ -121,20 +121,26 @@ function buildFullDaySlotEnd(dateKey: string, timezone: string) {
   return buildFullDaySlotStart(addDaysToDateKey(dateKey, 1), timezone);
 }
 
-function buildTimedFullDaySlotEnd({
+const timedFullDayCalendarDurationMinutes = 60;
+
+export function buildTimedFullDaySlotWindow({
   dateKey,
   fullDayStartMinutes,
-  meetingDurationMinutes,
   timezone,
 }: {
   dateKey: string;
   fullDayStartMinutes: number;
-  meetingDurationMinutes: number;
   timezone: string;
 }) {
   const slotStart = buildSlotStart(dateKey, fullDayStartMinutes, timezone);
+  const slotEnd = new Date(
+    new Date(slotStart).getTime() + timedFullDayCalendarDurationMinutes * 60 * 1000,
+  ).toISOString();
 
-  return new Date(new Date(slotStart).getTime() + meetingDurationMinutes * 60 * 1000).toISOString();
+  return {
+    slotStart,
+    slotEnd,
+  };
 }
 
 function getDateKeyInTimezone(date: Date, timezone: string) {
@@ -592,12 +598,11 @@ export function buildFinalizedSlot({
       slotEnd:
         fullDayStartMinutes === null || fullDayStartMinutes === undefined
           ? buildFullDaySlotEnd(slot.dateKey, timezone)
-          : buildTimedFullDaySlotEnd({
+          : buildTimedFullDaySlotWindow({
               dateKey: slot.dateKey,
               fullDayStartMinutes,
-              meetingDurationMinutes,
               timezone,
-            }),
+            }).slotEnd,
       dateKey: slot.dateKey,
       label: formatFullDayDateLabel({
         dateKey: slot.dateKey,
@@ -730,7 +735,6 @@ export function buildSnapshot({
           locale,
           timezone,
           fullDayStartMinutes,
-          meetingDurationMinutes,
           slots,
         })
       : rankBestSuggestions({
@@ -794,14 +798,12 @@ export function buildSnapshot({
 function rankBestFullDaySuggestions({
   dates,
   fullDayStartMinutes,
-  meetingDurationMinutes,
   locale,
   timezone,
   slots,
 }: {
   dates: string[];
   fullDayStartMinutes?: number | null;
-  meetingDurationMinutes: number;
   locale: AppLocale;
   timezone: string;
   slots: SnapshotSlot[];
@@ -821,12 +823,11 @@ function rankBestFullDaySuggestions({
         slotEnd:
           fullDayStartMinutes === null || fullDayStartMinutes === undefined
             ? buildFullDaySlotEnd(slot.dateKey, timezone)
-            : buildTimedFullDaySlotEnd({
+            : buildTimedFullDaySlotWindow({
                 dateKey: slot.dateKey,
                 fullDayStartMinutes,
-                meetingDurationMinutes,
                 timezone,
-              }),
+              }).slotEnd,
         dateKey: slot.dateKey,
         label: formatFullDayDateLabel({
           dateKey: slot.dateKey,