Skip to content

Commit 26a8f0a

Browse files
committed
fix: wrong return type of onDuplicateUpdate
1 parent 65c5c36 commit 26a8f0a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

__tests-tsd__/types.test-d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ const db = knex({});
1313
name: db.raw('Concat(name, "_test")'),
1414
});
1515

16-
const response = await db<{ id: number; name: string }>('table')
16+
const [{ insertId }] = await db<{ id: number; name: string }>('table')
1717
.insert({ id: 1, name: 'bla' })
1818
.onDuplicateUpdate('name', 'id', { name: db.raw('Concat(name, "_test")') });
19+
20+
const testId = insertId === 1 ? 1 : 0;
1921
})();

types.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ import { Knex } from 'knex';
22

33
declare module 'knex' {
44
namespace Knex {
5-
interface QueryBuilder<TRecord extends {} = any, TResult = any> {
5+
interface QueryBuilder<TRecord extends {} = any> {
66
onDuplicateUpdate(
77
...columnNames: Array<
88
| Knex.DbRecord<Knex.ResolveTableType<TRecord, 'insert'>>
99
| keyof TRecord
1010
>
11-
): Knex.QueryBuilder<TRecord, TResult>;
11+
): Knex.QueryBuilder<TRecord, any>;
1212
}
1313
}
1414
}

0 commit comments

Comments
 (0)