Skip to content

Clean up USB exercise #148

Open
Open
@jonathanpallant

Description

@jonathanpallant
  • "HEADS UP to use your USB packet parser uncomment line 12 and remove line 13" those line numbers are wrong
  • "SETUP: bmrequesttype: {}, brequest: {}, wlength: {}, windex: {}, wvalue: {}" could use some better formatting
  • consts::VID should be consts::USB_VID_DEMO
  • consts::PID should be consts::USB_PID_RTIC_DEMO
  • We should use pid.codes Test PIDs, like 0x000A, 0x000B and 0x000C, not random ones (we might collide with another pid.codes product in the future)
  • fn on_event et al, don't need to be inside the macro
  • the usbd module could be a struct with methods. Then people won't be tempted to try and read the registers by hand, when there are methods that do it for them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions