fix: ipc/server: only enter nonblocking state during cleanup

Author: xTrayambak

src/components/ipc/server/server.nim

@@ -187,14 +187,7 @@ proc acceptNewConnection*(server: var IPCServer) =
     conn: Socket
     address: string
 
-  while true:
-    try:
-      server.socket.acceptAddr(conn, address)
-      break
-    except OSError:
-      continue
-
-    sleep(150)
+  server.socket.acceptAddr(conn, address)
 
   info "New connection from: " & address
   let packet = server.receive(conn, HandshakePacket)
@@ -413,9 +406,7 @@ proc bindServerPath*(server: var IPCServer): string =
     InitializationFailed, "Windows/non *NIX systems are not supported yet. Sorry! :("
   )
 
-proc initialize*(server: var IPCServer, path: Option[string] = none string) {.inline.} =
-  debug "IPC server initializing"
-  # server.socket.setSockOpt(OptReusePort, true)
+proc setNonBlocking*(server: var IPCServer) =
   let flags = fcntl(server.socket.getFd(), F_GETFL, 0)
   if flags == -1:
     server.socket.close()
@@ -430,6 +421,10 @@ proc initialize*(server: var IPCServer, path: Option[string] = none string) {.in
       "fcntl(F_SETFL) returned -1; " & $strerror(errno) & " (" & $errno & ')',
     )
 
+proc initialize*(server: var IPCServer, path: Option[string] = none string) {.inline.} =
+  debug "IPC server initializing"
+  # server.socket.setSockOpt(OptReusePort, true)
+
   if path.isSome:
     server.socket.bindUnix(path.unsafeGet())
     server.path = unsafeGet path

src/components/master/master.nim

@@ -524,6 +524,7 @@ proc packetHandler*(
 
     # Here, we start sending "goodbye" packets to all processes.
     # We're essentially telling them, "Hey, start cleaning up and die."
+    master.server.setNonBlocking() # We do not want to block at this point. We won't be receiving anything now so it doesn't matter.
     for i, group in master.server.groups:
       for process in group:
         debug "Telling PID " & $process.pid & " (group " & $i & "'s " & $process.kind &

src/ferus.nim

@@ -72,7 +72,7 @@ proc main() {.inline.} =
     master.poll()
     for i, _ in tabs:
       tabs[i].heartbeat()
-
+  
   for tab in tabs:
     tab.master.server.close() # Shut down each tab's IPC master