refactor(SPRegistry): extract duration validation into _ensureDurationLimitsValid

Author: CodeWarriorr

src/SPRegistry.sol

@@ -571,15 +571,7 @@ contract SPRegistry is Initializable, AccessControlUpgradeable, UUPSUpgradeable,
         if (organization == address(0)) revert InvalidOrganizationAddress();
         if (capabilities.retrievabilityBps > 10_000) revert InvalidRetrievabilityBps(capabilities.retrievabilityBps);
         if (capabilities.indexingPct > 100) revert InvalidIndexingPct(capabilities.indexingPct);
-        if (minDealDurationDays > MAX_DEAL_DURATION_DAYS) {
-            revert DurationExceedsProtocolMax(minDealDurationDays, MAX_DEAL_DURATION_DAYS);
-        }
-        if (maxDealDurationDays != 0 && maxDealDurationDays > MAX_DEAL_DURATION_DAYS) {
-            revert DurationExceedsProtocolMax(maxDealDurationDays, MAX_DEAL_DURATION_DAYS);
-        }
-        if (minDealDurationDays != 0 && maxDealDurationDays != 0 && minDealDurationDays > maxDealDurationDays) {
-            revert MinDurationExceedsMax(minDealDurationDays, maxDealDurationDays);
-        }
+        _ensureDurationLimitsValid(minDealDurationDays, maxDealDurationDays);
 
         _registerProvider(provider, organization, payee);
 
@@ -627,15 +619,7 @@ contract SPRegistry is Initializable, AccessControlUpgradeable, UUPSUpgradeable,
         _ensureProviderRegistered(provider);
         _ensureProviderNotBlocked(provider);
         _onlyProviderControllerOrAdmin(provider);
-        if (minDealDurationDays > MAX_DEAL_DURATION_DAYS) {
-            revert DurationExceedsProtocolMax(minDealDurationDays, MAX_DEAL_DURATION_DAYS);
-        }
-        if (maxDealDurationDays != 0 && maxDealDurationDays > MAX_DEAL_DURATION_DAYS) {
-            revert DurationExceedsProtocolMax(maxDealDurationDays, MAX_DEAL_DURATION_DAYS);
-        }
-        if (minDealDurationDays != 0 && maxDealDurationDays != 0 && minDealDurationDays > maxDealDurationDays) {
-            revert MinDurationExceedsMax(minDealDurationDays, maxDealDurationDays);
-        }
+        _ensureDurationLimitsValid(minDealDurationDays, maxDealDurationDays);
 
         SPRegistryStorage storage $ = _getSPRegistryStorage();
         uint64 id = CommonTypes.FilActorId.unwrap(provider);
@@ -707,6 +691,23 @@ contract SPRegistry is Initializable, AccessControlUpgradeable, UUPSUpgradeable,
         }
     }
 
+    /**
+     * @notice Ensures deal duration limits are within the protocol maximum and internally consistent
+     * @param minDealDurationDays The minimum deal duration to validate
+     * @param maxDealDurationDays The maximum deal duration to validate
+     */
+    function _ensureDurationLimitsValid(uint32 minDealDurationDays, uint32 maxDealDurationDays) internal pure {
+        if (minDealDurationDays > MAX_DEAL_DURATION_DAYS) {
+            revert DurationExceedsProtocolMax(minDealDurationDays, MAX_DEAL_DURATION_DAYS);
+        }
+        if (maxDealDurationDays != 0 && maxDealDurationDays > MAX_DEAL_DURATION_DAYS) {
+            revert DurationExceedsProtocolMax(maxDealDurationDays, MAX_DEAL_DURATION_DAYS);
+        }
+        if (minDealDurationDays != 0 && maxDealDurationDays != 0 && minDealDurationDays > maxDealDurationDays) {
+            revert MinDurationExceedsMax(minDealDurationDays, maxDealDurationDays);
+        }
+    }
+
     /**
      * @notice Ensures a provider is not blocked
      * @param provider The provider actor ID to check