small impr

Author: CodeWarriorr

url_finder/src/background/url_discovery_scheduler.rs

@@ -93,6 +93,8 @@ async fn schedule_url_discoveries(
             test_provider_with_clients(config, &provider.provider_id, clients, deal_repo).await;
 
         // Extract provider-only result for storage_providers update
+        // None case: provider-only discovery missing (panic, filtering, etc.) - default is_consistent
+        // to false since consistency was not verified
         let provider_discovery = results.iter().find(|r| r.client_id.is_none());
 
         let (last_working_url, is_consistent, is_reliable, url_metadata) = match provider_discovery
@@ -103,7 +105,7 @@ async fn schedule_url_discoveries(
                 r.is_reliable,
                 r.url_metadata.clone(),
             ),
-            None => (None, true, false, None),
+            None => (None, false, false, None),
         };
 
         let url_results: Vec<UrlResult> = results.into_iter().map(|r| r.into()).collect();

url_finder/tests/integration_tests/bms_result_repo.rs

@@ -307,7 +307,7 @@ async fn test_get_history_for_provider() {
 
     let provider = provider_id(TEST_PROVIDER_1_DB);
 
-    // Insert 3 results
+    // Insert 3 results with small delays to ensure unique timestamps
     for i in 0..3 {
         let job_id = Uuid::new_v4();
         repo.insert_pending(&provider, job_id, TEST_WORKING_URL, "us_east", 3)
@@ -316,16 +316,22 @@ async fn test_get_history_for_provider() {
         repo.update_completed(job_id, "Completed", Some(10.0 + i as f64), None, None, None)
             .await
             .unwrap();
+        // Sleep between iterations to ensure unique created_at timestamps
+        // so the ordering assertion is meaningfully validated
+        if i < 2 {
+            tokio::time::sleep(tokio::time::Duration::from_millis(2)).await;
+        }
     }
 
     // Get history with limit 2
     let history = repo.get_history_for_provider(&provider, 2).await.unwrap();
 
     assert_eq!(history.len(), 2);
     // Verify ordered by created_at DESC (most recent first)
+    // Use strict inequality to confirm timestamps are actually different
     assert!(
-        history[0].created_at >= history[1].created_at,
-        "History should be ordered by created_at DESC: first={:?}, second={:?}",
+        history[0].created_at > history[1].created_at,
+        "History should be ordered by created_at DESC with distinct timestamps: first={:?}, second={:?}",
         history[0].created_at,
         history[1].created_at
     );

url_finder/tests/integration_tests/extended_response.rs

@@ -191,18 +191,19 @@ async fn test_get_provider_extended_response_has_scheduling() {
     );
 
     // scheduling should be present when SP record exists
-    let scheduling = body.get("scheduling");
-    if let Some(sched) = scheduling {
-        // Verify scheduling structure
-        assert!(
-            sched.get("url_discovery").is_some(),
-            "scheduling.url_discovery should exist"
-        );
-        assert!(
-            sched.get("bms_test").is_some(),
-            "scheduling.bms_test should exist"
-        );
-    }
+    let scheduling = body
+        .get("scheduling")
+        .expect("scheduling should be present in extended response");
+
+    // Verify scheduling structure
+    assert!(
+        scheduling.get("url_discovery").is_some(),
+        "scheduling.url_discovery should exist"
+    );
+    assert!(
+        scheduling.get("bms_test").is_some(),
+        "scheduling.bms_test should exist"
+    );
 }
 
 #[tokio::test]