Skip to content

Commit 6c00345

Browse files
committed
Fix regex/tests
1 parent 9a2bfcd commit 6c00345

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,9 @@ async function run() {
164164
* Useful for later using `aws ecs describe-task-definition` to get the full ARN,
165165
* since outputting full ARN can be misinterpreted as a secret by Github Actions.
166166
*/
167-
const regex = new RegExp('/task-definition/([A-Z0-9-_]+):([0-9]+)/');
168-
const matches = 'https://vine.co/v/Mipm1LMKVqJ/embed'.match(regex);
169-
core.setOutput('task-definition-family-and-revision', `${matches[1]}:${matches[2]}`)
167+
const regex = new RegExp(':task-definition/(.*)$');
168+
const matches = taskDefRevisionArn.match(regex);
169+
core.setOutput('task-definition-family-and-revision', matches[1])
170170

171171
const clusterName = cluster ? cluster : 'default';
172172

index.test.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ describe('Deploy to ECS', () => {
6363
mockEcsRegisterTaskDef.mockImplementation(() => {
6464
return {
6565
promise() {
66-
return Promise.resolve({ taskDefinition: { taskDefinitionArn: 'task:def:arn' } });
66+
return Promise.resolve({ taskDefinition: { taskDefinitionArn: 'task:def:arn:task-definition/task-def-family:1' } });
6767
}
6868
};
6969
});
@@ -132,10 +132,11 @@ describe('Deploy to ECS', () => {
132132
await run();
133133
expect(core.setFailed).toHaveBeenCalledTimes(0);
134134
expect(mockEcsRegisterTaskDef).toHaveBeenNthCalledWith(1, { family: 'task-def-family'});
135-
expect(core.setOutput).toHaveBeenNthCalledWith(1, 'task-definition-arn', 'task:def:arn');
135+
expect(core.setOutput).toBeCalledWith('task-definition-arn', 'task:def:arn:task-definition/task-def-family:1');
136+
expect(core.setOutput).toBeCalledWith('task-definition-family-and-revision', 'task-def-family:1');
136137
expect(mockRunTasks).toHaveBeenNthCalledWith(1, {
137138
cluster: 'cluster-789',
138-
taskDefinition: 'task:def:arn',
139+
taskDefinition: 'task:def:arn:task-definition/task-def-family:1',
139140
count: '1',
140141
startedBy: 'amazon-ecs-run-task-for-github-actions',
141142
networkConfiguration: {
@@ -166,13 +167,15 @@ describe('Deploy to ECS', () => {
166167
expect(core.setFailed).toHaveBeenCalledTimes(0);
167168

168169
expect(mockEcsRegisterTaskDef).toHaveBeenNthCalledWith(1, { family: 'task-def-family'});
169-
expect(core.setOutput).toHaveBeenNthCalledWith(1, 'task-definition-arn', 'task:def:arn');
170+
expect(core.setOutput).toBeCalledWith('task-definition-arn', 'task:def:arn:task-definition/task-def-family:1');
171+
expect(core.setOutput).toBeCalledWith('task-definition-family-and-revision', 'task-def-family:1');
170172
expect(mockEcsDescribeTasks).toHaveBeenNthCalledWith(1, {
171173
cluster: 'cluster-789',
172174
tasks: ['arn:aws:ecs:fake-region:account_id:task/arn']
173175
});
174176

175177
expect(mockEcsWaiter).toHaveBeenCalledTimes(1);
178+
expect(core.setOutput).toBeCalledWith('task-arn', ['arn:aws:ecs:fake-region:account_id:task/arn']);
176179

177180
expect(core.info).toBeCalledWith("All tasks have exited successfully.");
178181
});

0 commit comments

Comments
 (0)