feat: detect running on desktop, disable power/lid events for it (#80)

## What does this PR do?

Disables power events on desktops by default (still enabled on laptops).

## Why is this change important?

User requested in #79 

## How to test this PR locally?

`make pre-push`

## Related issues

Closes #79

Author: fiffeek

README.md

@@ -143,7 +143,7 @@ See the [`examples/`](https://github.com/fiffeek/hyprdynamicmonitors/tree/main/e
 ## Runtime Requirements
 
 - Hyprland with IPC support
-- UPower (required, unless `--disable-power-events` is passed, for power state monitoring)
+- UPower (required on laptops, unless `--disable-power-events` is passed, for power state monitoring)
 - D-Bus access (required if power events, lid state or notifications are enabled)
 
 ## Alternative Software

cmd/run.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"github.com/fiffeek/hyprdynamicmonitors/internal/app"
+	"github.com/fiffeek/hyprdynamicmonitors/internal/utils"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 )
@@ -24,6 +25,16 @@ var runCmd = &cobra.Command{
 	Long:  `Run the HyprDynamicMonitors service to continuously monitor for display changes and automatically apply matching configuration profiles.`,
 	RunE: func(cmd *cobra.Command, args []string) error {
 		logrus.WithField("version", Version).Debug("Starting Hyprland Dynamic Monitor Manager")
+
+		// If the flag wasn't provided, power events are enabled, and not running on a laptop, then default to --disable-power-events
+		if !cmd.Flags().Changed("disable-power-events") && !disablePowerEvents && !utils.IsLaptop() {
+			disablePowerEvents = true
+			logrus.WithFields(utils.NewLogrusCustomFields(logrus.Fields{
+				"disable-power-events": disablePowerEvents,
+			}).WithLogID(utils.DisablingPowerEventsLogID)).Info(
+				"Running on desktop. Disabling power events. If this is not what you want, run with `--disable-power-events=false`.")
+		}
+
 		ctx, cancel := context.WithCancelCause(context.Background())
 		app, err := app.NewApplication(&configPath, &dryRun, ctx, cancel, &disablePowerEvents,
 			&disableAutoHotReload, &connectToSessionBus, &enableLidEvents)
@@ -60,7 +71,7 @@ func init() {
 		&disablePowerEvents,
 		"disable-power-events",
 		false,
-		"Disable power events (dbus)",
+		"Disable power events (dbus). Defaults to true if running on desktop, to false otherwise",
 	)
 	runCmd.Flags().BoolVar(
 		&connectToSessionBus,

cmd/tui.go

@@ -8,6 +8,7 @@ import (
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/charmbracelet/lipgloss"
 	"github.com/fiffeek/hyprdynamicmonitors/internal/app"
+	"github.com/fiffeek/hyprdynamicmonitors/internal/utils"
 	"github.com/muesli/termenv"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
@@ -23,6 +24,15 @@ var tuiCmd = &cobra.Command{
 	Short: "Launch interactive TUI for monitor configuration",
 	Long:  `Launch an interactive terminal-based TUI for managing monitor configurations.`,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		// If the flag wasn't provided, power events are enabled, and not running on a laptop, then default to --disable-power-events
+		if !cmd.Flags().Changed("disable-power-events") && !disablePowerEvents && !utils.IsLaptop() {
+			disablePowerEvents = true
+			logrus.WithFields(utils.NewLogrusCustomFields(logrus.Fields{
+				"disable-power-events": disablePowerEvents,
+			}).WithLogID(utils.DisablingPowerEventsLogID)).Info(
+				"Running on desktop. Disabling power events. If this is not what you want, run with `--disable-power-events=false`.")
+		}
+
 		if debug {
 			f, err := tea.LogToFile("debug.log", "debug")
 			if err != nil {
@@ -67,7 +77,7 @@ func init() {
 		&disablePowerEvents,
 		"disable-power-events",
 		false,
-		"Disable power events (dbus)",
+		"Disable power events (dbus). Defaults to true if running on desktop, to false otherwise",
 	)
 
 	tuiCmd.Flags().BoolVar(

docs/docs/configuration/power-events.md

@@ -21,6 +21,15 @@ When disabled:
 - No power events will be delivered
 - No D-Bus connection will be made
 
+## Enabling Power Events
+
+Power events are enabled by default on laptops. They are disabled on desktops (the current chassis type is pulled from `/sys/class/dmi/id/chassis_type`).
+If you want to enable them anyway, run, e.g.:
+
+```bash
+hyprdynamicmonitors run --disable-power-events=false
+```
+
 ## Default Configuration
 
 By default, the service listens for D-Bus signals:

docs/docs/faq.md

@@ -214,6 +214,16 @@ Yes! HyprDynamicMonitors can work alongside `nwg-displays`:
 
 This combines the visual configuration of `nwg-displays` with the automatic profile management of `hyprdynamicmonitors`.
 
+## Is UPower Running? UPower misconfigured or not running: failed to get property from UPower: Object does not exist at path “/org/freedesktop/UPower/devices/line_power_ACAD”
+
+If you got this error, you either want to:
+1. If you do not want to use power events (e.g., on a desktop), pass the `--disable-power-events` CLI argument
+2. Tweak your [Power Events configuration](./configuration/power-events.md) to use the proper device path (`upower -e` to find your `line_power` device; additionally, it would be helpful if you added it [here](https://github.com/fiffeek/hyprdynamicmonitors/blob/main/internal/utils/power.go#L14) so that others do not encounter this issue going forward)
+
+If you are running on a desktop with a version of `hyprdynamicmonitors` that includes [this patch](https://github.com/fiffeek/hyprdynamicmonitors/pull/80) (`v1.3.5+`),
+this error should not occur unless `--disable-power-events=false` is explicitly passed, since power events are disabled
+for desktops by default. Please [open an issue](https://github.com/fiffeek/hyprdynamicmonitors/issues) and include the output of `cat /sys/class/dmi/id/chassis_type`.
+
 ## See Also
 
 - [Examples](https://github.com/fiffeek/hyprdynamicmonitors/tree/main/examples) - Complete configuration examples

docs/docs/quickstart/setup-approaches.md

@@ -9,7 +9,14 @@ Choose your preferred setup approach based on whether you want to run the daemon
 ## Choose Your Approach
 
 :::warning
-When running the daemon with power or lid events enabled, make sure that `UPower` is installed and its service is running.
+The app will try to detect your chassis type from `/sys/class/dmi/id/chassis_type` on startup.
+If a desktop is detected, it will disable power events unless explicitly enabled (by passing `--disable-power-events=false`).
+On laptops, power events are enabled by default (pass `--disable-power-events` to disable them).
+:::
+
+:::warning
+When running the daemon with power (default) or lid events enabled, make sure that `UPower` is installed and its service is running.
+If you're running on a desktop you likely want both disabled (pass `--disable-power-events`).
 :::
 
 ### Option A: TUI + Daemon (Recommended for Most Users)

docs/docs/usage/commands.md

@@ -55,7 +55,7 @@ Usage:
 Flags:
       --connect-to-session-bus    Connect to session bus instead of system bus for power events: https://wiki.archlinux.org/title/D-Bus. You can switch as long as you expose power line events in your user session bus.
       --disable-auto-hot-reload   Disable automatic hot reload (no file watchers)
-      --disable-power-events      Disable power events (dbus)
+      --disable-power-events      Disable power events (dbus). Defaults to true if running on desktop, to false otherwise
       --dry-run                   Show what would be done without making changes
       --enable-lid-events         Enable listening to dbus lid events
   -h, --help                      help for run
@@ -221,7 +221,7 @@ Usage:
 
 Flags:
       --connect-to-session-bus          Connect to session bus instead of system bus for power events: https://wiki.archlinux.org/title/D-Bus. You can switch as long as you expose power line events in your user session bus.
-      --disable-power-events            Disable power events (dbus)
+      --disable-power-events            Disable power events (dbus). Defaults to true if running on desktop, to false otherwise
       --enable-lid-events               Enable listening to dbus lid events
   -h, --help                            help for tui
       --hypr-monitors-override string   When used it fill parse the given file as hyprland monitors spec, used for testing.

internal/utils/dmi.go

@@ -0,0 +1,73 @@
+package utils
+
+import (
+	"fmt"
+	"os"
+	"strconv"
+	"strings"
+
+	"github.com/sirupsen/logrus"
+)
+
+var (
+	dmiPathEnvVarOverride = "HYPRDYNAMICMONITORS_DMI_PATH_OVERRIDE"
+	dmiPath               = "/sys/class/dmi/id/chassis_type"
+)
+
+// laptopLikeCodes are the SMBIOS/ DMI chassis_type numeric codes that indicate "laptop-like".
+var laptopLikeCodes = map[int]struct{}{
+	8:  {}, // Portable
+	9:  {}, // Laptop
+	10: {}, // Notebook
+	14: {}, // Sub Notebook
+	31: {}, // Convertible
+	32: {}, // Detachable
+}
+
+func readChassisType() (int, error) {
+	path, ok := os.LookupEnv(dmiPathEnvVarOverride)
+	if !ok {
+		path = dmiPath
+	}
+
+	//nolint:gosec
+	dmiContents, err := os.ReadFile(path)
+	if err != nil {
+		return 0, fmt.Errorf("can't read chassis type: %w", err)
+	}
+	s := strings.TrimSpace(string(dmiContents))
+
+	// Some kernels expose numeric; some distros might echo names (rare). Try parsing int first.
+	if num, err := strconv.Atoi(s); err == nil {
+		return num, nil
+	}
+
+	// fallback: map some textual values to numbers (if present)
+	// common textual outputs: "Notebook", "Laptop", "Desktop"
+	switch strings.ToLower(s) {
+	case "portable":
+		return 8, nil
+	case "laptop", "notebook":
+		return 10, nil
+	case "sub-notebook", "sub notebook":
+		return 14, nil
+	case "desktop":
+		return 3, nil
+	case "server":
+		return 17, nil
+	default:
+		return 0, nil
+	}
+}
+
+func IsLaptop() bool {
+	dmiCode, err := readChassisType()
+	if err != nil {
+		logrus.WithError(err).Warn("can't read DMI code")
+		// assume laptop for backwards compatibility
+		return true
+	}
+
+	_, ok := laptopLikeCodes[dmiCode]
+	return ok
+}