fix: inline the command strings

alanshaw · alanshaw · commit 4a95fe5ae753 · 2026-05-19T14:26:03.000+01:00
diff --git a/commands/access/request.go b/commands/access/request.go
@@ -9,11 +9,9 @@ import "github.com/fil-forge/libforge/commands"
 // invocation.
 const RequestMetaKey = "accessRequest"
 
-const RequestCommand = "/access/request"
-
 // Request can be invoked by an agent to request set of capabilities from the
 // account.
-var Request = commands.MustParse[*RequestArguments](RequestCommand)
+var Request = commands.MustParse[*RequestArguments]("/access/request")
 
 const (
 	InvalidAuthorizationAccountErrorName  = "InvalidAuthorizationAccount"
diff --git a/commands/assert/equals.go b/commands/assert/equals.go
@@ -4,9 +4,7 @@ package assert
 
 import "github.com/fil-forge/libforge/commands"
 
-const EqualsCommand = "/assert/equals"
-
 type EqualsOK = commands.Unit
 
 // Equals claims data is referred to by another CID e.g CAR CID & Piece CID
-var Equals = commands.MustParse[*EqualsArguments](EqualsCommand)
+var Equals = commands.MustParse[*EqualsArguments]("/assert/equals")
diff --git a/commands/assert/index.go b/commands/assert/index.go
@@ -4,10 +4,8 @@ package assert
 
 import "github.com/fil-forge/libforge/commands"
 
-const IndexCommand = "/assert/index"
-
 type IndexOK = commands.Unit
 
 // Index claims that a content graph can be found in blob(s) that are identified
 // and indexed in the given index CID.
-var Index = commands.MustParse[*IndexArguments](IndexCommand)
+var Index = commands.MustParse[*IndexArguments]("/assert/index")
diff --git a/commands/assert/location.go b/commands/assert/location.go
@@ -4,8 +4,6 @@ package assert
 
 import "github.com/fil-forge/libforge/commands"
 
-const LocationCommand = "/assert/location"
-
 type LocationOK = commands.Unit
 
-var Location = commands.MustParse[*LocationArguments](LocationCommand)
+var Location = commands.MustParse[*LocationArguments]("/assert/location")
diff --git a/commands/blob/accept.go b/commands/blob/accept.go
@@ -4,6 +4,4 @@ package blob
 
 import "github.com/fil-forge/libforge/commands"
 
-const AcceptCommand = "/blob/accept"
-
-var Accept = commands.MustParse[*AcceptArguments](AcceptCommand)
+var Accept = commands.MustParse[*AcceptArguments]("/blob/accept")
diff --git a/commands/blob/list.go b/commands/blob/list.go
@@ -4,6 +4,4 @@ package blob
 
 import "github.com/fil-forge/libforge/commands"
 
-const ListCommand = "/blob/list"
-
-var List = commands.MustParse[*ListArguments](ListCommand)
+var List = commands.MustParse[*ListArguments]("/blob/list")
diff --git a/commands/blob/remove.go b/commands/blob/remove.go
@@ -4,8 +4,6 @@ package blob
 
 import "github.com/fil-forge/libforge/commands"
 
-const RemoveCommand = "/blob/remove"
-
 type RemoveOK = commands.Unit
 
-var Remove = commands.MustParse[*RemoveArguments](RemoveCommand)
+var Remove = commands.MustParse[*RemoveArguments]("/blob/remove")
diff --git a/commands/blob/retrieve.go b/commands/blob/retrieve.go
@@ -4,8 +4,6 @@ package blob
 
 import "github.com/fil-forge/libforge/commands"
 
-const RetrieveCommand = "/blob/retrieve"
-
 // Retrieve is the service-level retrieval capability (e.g. used by the
 // indexer to fetch content claims from a Piri node). It is NOT space-scoped:
 // any holder of a valid delegation for `/blob/retrieve` may fetch the blob
@@ -14,4 +12,4 @@ const RetrieveCommand = "/blob/retrieve"
 // For user-facing retrieval that requires an allocation in a specific space
 // see `libforge/commands/content.Retrieve` (the `/content/retrieve`
 // capability).
-var Retrieve = commands.MustParse[*RetrieveArguments](RetrieveCommand)
+var Retrieve = commands.MustParse[*RetrieveArguments]("/blob/retrieve")
diff --git a/commands/claim/cache.go b/commands/claim/cache.go
@@ -4,8 +4,6 @@ package claim
 
 import "github.com/fil-forge/libforge/commands"
 
-const CacheCommand = "/claim/cache"
-
 type CacheOK = commands.Unit
 
-var Cache = commands.MustParse[*CacheArguments](CacheCommand)
+var Cache = commands.MustParse[*CacheArguments]("/claim/cache")
diff --git a/commands/content/retrieve.go b/commands/content/retrieve.go
@@ -4,8 +4,6 @@ package content
 
 import "github.com/fil-forge/libforge/commands"
 
-const RetrieveCommand = "/content/retrieve"
-
 type RetrieveOK = commands.Unit
 
-var Retrieve = commands.MustParse[*RetrieveArguments](RetrieveCommand)
+var Retrieve = commands.MustParse[*RetrieveArguments]("/content/retrieve")
diff --git a/commands/http/put.go b/commands/http/put.go
@@ -4,8 +4,6 @@ package http
 
 import "github.com/fil-forge/libforge/commands"
 
-const PutCommand = "/http/put"
-
 type PutOK = commands.Unit
 
-var Put = commands.MustParse[*PutArguments](PutCommand)
+var Put = commands.MustParse[*PutArguments]("/http/put")
diff --git a/commands/index/add.go b/commands/index/add.go
@@ -7,11 +7,9 @@ import (
 	"github.com/fil-forge/ucantone/errors"
 )
 
-const AddCommand = "/index/add"
-
 type AddOK = commands.Unit
 
-var Add = commands.MustParse[*AddArguments](AddCommand)
+var Add = commands.MustParse[*AddArguments]("/index/add")
 
 const IndexNotFoundErrorName = "IndexNotFound"
 
diff --git a/commands/provider/add.go b/commands/provider/add.go
@@ -7,9 +7,7 @@ import (
 	"github.com/fil-forge/ucantone/errors"
 )
 
-const AddCommand = "/provider/add"
-
-var Add = commands.MustParse[*AddArguments](AddCommand)
+var Add = commands.MustParse[*AddArguments]("/provider/add")
 
 const (
 	InvalidAccountErrorName     = "InvalidAccount"
diff --git a/commands/space/egress/track.go b/commands/space/egress/track.go
@@ -4,11 +4,9 @@ package egress
 
 import "github.com/fil-forge/libforge/commands"
 
-const TrackCommand = "/space/egress/track"
-
 // Track is the capability a storage node invokes to ask the egress
 // tracking service to record egress accounted for in a batch of
 // `/content/retrieve` receipts. The tracking service responds by forking
 // a `/space/egress/consolidate` sub-invocation onto the receipt's
 // effects; the typed OK return is empty.
-var Track = commands.MustParse[*TrackArguments](TrackCommand)
+var Track = commands.MustParse[*TrackArguments]("/space/egress/track")
diff --git a/commands/space/info.go b/commands/space/info.go
@@ -4,10 +4,8 @@ package space
 
 import "github.com/fil-forge/libforge/commands"
 
-const InfoCommand = "/space/info"
-
 type InfoArguments = commands.Unit
 
-var Info = commands.MustParse[*InfoArguments](InfoCommand)
+var Info = commands.MustParse[*InfoArguments]("/space/info")
 
 const UnknownSpaceErrorName = "UnknownSpace"
diff --git a/commands/ucan/attest/proof.go b/commands/ucan/attest/proof.go
@@ -4,10 +4,8 @@ package attest
 
 import "github.com/fil-forge/libforge/commands"
 
-const ProofCommand = "/ucan/attest/proof"
-
 type ProofOK = commands.Unit
 
 // Issued by a trusted authority (usually the one handling invocation) that
 // attests a specific UCAN delegation has been considered authentic.
-var Proof = commands.MustParse[*ProofArguments](ProofCommand)
+var Proof = commands.MustParse[*ProofArguments]("/ucan/attest/proof")
diff --git a/commands/ucan/conclude.go b/commands/ucan/conclude.go
@@ -7,11 +7,9 @@ import (
 	"github.com/fil-forge/ucantone/errors"
 )
 
-const ConcludeCommand = "/ucan/conclude"
-
 type ConcludeOK = commands.Unit
 
-var Conclude = commands.MustParse[*ConcludeArguments](ConcludeCommand)
+var Conclude = commands.MustParse[*ConcludeArguments]("/ucan/conclude")
 
 const ConclusionReceiptNotFoundErrorName = "ConclusionReceiptNotFound"
 
diff --git a/commands/upload/add.go b/commands/upload/add.go
@@ -4,8 +4,6 @@ package upload
 
 import "github.com/fil-forge/libforge/commands"
 
-const AddCommand = "/upload/add"
-
 type AddOK = commands.Unit
 
-var Add = commands.MustParse[*AddArguments](AddCommand)
+var Add = commands.MustParse[*AddArguments]("/upload/add")
diff --git a/commands/upload/list.go b/commands/upload/list.go
@@ -4,6 +4,4 @@ package upload
 
 import "github.com/fil-forge/libforge/commands"
 
-const ListCommand = "/upload/list"
-
-var List = commands.MustParse[*ListArguments](ListCommand)
+var List = commands.MustParse[*ListArguments]("/upload/list")
diff --git a/commands/upload/remove.go b/commands/upload/remove.go
@@ -4,8 +4,6 @@ package upload
 
 import "github.com/fil-forge/libforge/commands"
 
-const RemoveCommand = "/upload/remove"
-
 type RemoveOK = commands.Unit
 
-var Remove = commands.MustParse[*RemoveArguments](RemoveCommand)
+var Remove = commands.MustParse[*RemoveArguments]("/upload/remove")
diff --git a/commands/upload/shard/list.go b/commands/upload/shard/list.go
@@ -4,6 +4,4 @@ package shard
 
 import "github.com/fil-forge/libforge/commands"
 
-const ListCommand = "/upload/shard/list"
-
-var List = commands.MustParse[*ListArguments](ListCommand)
+var List = commands.MustParse[*ListArguments]("/upload/shard/list")
diff --git a/ucan/attestations.go b/ucan/attestations.go
@@ -27,7 +27,7 @@ func ProofAttestations(ctx context.Context, listInvocations InvocationListerFunc
 			continue
 		}
 		var attestation ucan.Invocation
-		for inv, err := range listInvocations(ctx, proof.Audience(), attest.ProofCommand, authority) {
+		for inv, err := range listInvocations(ctx, proof.Audience(), ucan.Command(attest.Proof), authority) {
 			if err != nil {
 				return nil, fmt.Errorf("listing invocations for proof signed by %q: %w", proof.Issuer(), err)
 			}
diff --git a/ucan/attestations_test.go b/ucan/attestations_test.go
@@ -105,7 +105,7 @@ func TestProofAttestations(t *testing.T) {
 		// Lister should be called with the proof's audience, the /ucan/attest/proof
 		// command, and the authority as subject.
 		require.Equal(t, agent.DID(), calls[0].aud)
-		require.Equal(t, ucan.Command(attest.ProofCommand), calls[0].cmd)
+		require.Equal(t, ucan.Command(attest.Proof), calls[0].cmd)
 		require.Equal(t, service.DID(), calls[0].sub)
 	})
 
