fix: pdp bits and add a CI rule

Author: frrist

.github/workflows/codegen.yml

@@ -0,0 +1,29 @@
+name: Codegen
+
+on:
+  pull_request:
+  push:
+    branches: ["main"]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event_name == 'push' && github.sha || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  codegen:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+      # Compile the generators under the `codegen` build tag. The reusable
+      # go-check/go-test workflows build without this tag, so a generator that
+      # no longer compiles would otherwise slip through CI.
+      - run: make codegen-build
+      # Run `go generate` and fail if the committed generated files are stale.
+      - run: make gen-check

Makefile

@@ -1,4 +1,4 @@
-.PHONY: gen build test
+.PHONY: gen build test codegen-build gen-check ci
 
 gen:
 	go generate ./...
@@ -8,3 +8,19 @@ build:
 
 test:
 	go test ./...
+
+# Compile the code generators under the `codegen` build tag they actually run
+# with. A normal `go build ./...` never sets this tag, so a generator that no
+# longer compiles (e.g. it references a renamed or removed type) would otherwise
+# go unnoticed until someone runs `go generate`.
+codegen-build:
+	go build -tags codegen $(shell go list ./... | grep '/gen$$')
+
+# Regenerate everything and fail if the committed output changed, catching both
+# generators that no longer compile and generated files that are out of date.
+gen-check: gen
+	@git diff --exit-code -- '*_gen.go' '*_gen.*.go' || \
+		{ echo "generated files are out of date; run 'make gen' and commit the result" >&2; exit 1; }
+
+# Aggregate target suitable for CI.
+ci: build codegen-build gen-check test

commands/pdp/sign/sign.go

@@ -16,8 +16,8 @@ type (
 )
 
 var (
-	DataSetCreate        = commands.MustParse[*DataSetCreateArguments, *DataSetCreateOK]("/pdp/sign/dataset/create")
-	DataSetDelete        = commands.MustParse[*DataSetDeleteArguments, *DataSetDeleteOK]("/pdp/sign/dataset/delete")
-	PiecesAdd            = commands.MustParse[*PiecesAddArguments, *PiecesAddOK]("/pdp/sign/pieces/add")
-	PiecesRemoveSchedule = commands.MustParse[*PiecesRemoveScheduleArguments, *PiecesRemoveScheduleOK]("/pdp/sign/pieces/remove/schedule")
+	DataSetCreate        = commands.MustParse[*DataSetCreateArguments]("/pdp/sign/dataset/create")
+	DataSetDelete        = commands.MustParse[*DataSetDeleteArguments]("/pdp/sign/dataset/delete")
+	PiecesAdd            = commands.MustParse[*PiecesAddArguments]("/pdp/sign/pieces/add")
+	PiecesRemoveSchedule = commands.MustParse[*PiecesRemoveScheduleArguments]("/pdp/sign/pieces/remove/schedule")
 )