fix: wildcard matching

Author: alanshaw

ucan/delegation/policy/match.go

@@ -132,7 +132,7 @@ func MatchStatement(statement ucan.Statement, value any) (bool, error) {
 		if !ok {
 			return false, NewMatchError(statement, fmt.Errorf(`matching "%s": "%v" is not applicable to operator "%s"`, s.Selector(), one, OpLike))
 		}
-		if s.glob.Match(v) {
+		if !s.glob.Match(v) {
 			return false, NewMatchError(statement, fmt.Errorf(`matching "%s": "%v" is not like "%v"`, s.Selector(), one, s.model.Pattern))
 		}
 		return true, nil

ucan/delegation/policy/match_test.go

@@ -356,6 +356,54 @@ func TestMatch(t *testing.T) {
 			value: 138,
 			match: false,
 		},
+		{
+			name:   "wildcard match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob, Carol.",
+			match:  true,
+		},
+		{
+			name:   "wildcard match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob, Dan, Erin, Carol.",
+			match:  true,
+		},
+		{
+			name:   "wildcard match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob  , Carol.",
+			match:  true,
+		},
+		{
+			name:   "wildcard match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob*, Carol.",
+			match:  true,
+		},
+		{
+			name:   "wildcard no match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob, Carol",
+			match:  false,
+		},
+		{
+			name:   "wildcard no match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice*, Bob*, Carol!",
+			match:  false,
+		},
+		{
+			name:   "wildcard no match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  "Alice, Bob, Carol.",
+			match:  false,
+		},
+		{
+			name:   "wildcard no match",
+			policy: policy.Like(".", `Alice\*, Bob*, Carol.`),
+			value:  " Alice*, Bob, Carol. ",
+			match:  false,
+		},
 	}
 
 	for _, tc := range testCases {
@@ -373,51 +421,6 @@ func TestMatch(t *testing.T) {
 		})
 	}
 
-	// t.Run("wildcard", func(t *testing.T) {
-	// 	glb, err := glob.Compile(`Alice\*, Bob*, Carol.`)
-	// 	require.NoError(t, err)
-
-	// 	for _, s := range []string{
-	// 		"Alice*, Bob, Carol.",
-	// 		"Alice*, Bob, Dan, Erin, Carol.",
-	// 		"Alice*, Bob  , Carol.",
-	// 		"Alice*, Bob*, Carol.",
-	// 	} {
-	// 		func(s string) {
-	// 			t.Run(fmt.Sprintf("pass %s", s), func(t *testing.T) {
-	// 				np := basicnode.Prototype.String
-	// 				nb := np.NewBuilder()
-	// 				nb.AssignString(s)
-	// 				nd := nb.Build()
-
-	// 				pol := policy.Policy{Like(mustParse(t, "."), glb)}
-	// 				ok, err := policy.Match(pol, nd)
-	// 				require.True(t, ok)
-	// 			})
-	// 		}(s)
-	// 	}
-
-	// 	for _, s := range []string{
-	// 		"Alice*, Bob, Carol",
-	// 		"Alice*, Bob*, Carol!",
-	// 		"Alice, Bob, Carol.",
-	// 		" Alice*, Bob, Carol. ",
-	// 	} {
-	// 		func(s string) {
-	// 			t.Run(fmt.Sprintf("fail %s", s), func(t *testing.T) {
-	// 				np := basicnode.Prototype.String
-	// 				nb := np.NewBuilder()
-	// 				nb.AssignString(s)
-	// 				nd := nb.Build()
-
-	// 				pol := policy.Policy{Like(mustParse(t, "."), glb)}
-	// 				ok, err := policy.Match(pol, nd)
-	// 				require.False(t, ok)
-	// 			})
-	// 		}(s)
-	// 	}
-	// })
-
 	// t.Run("quantification", func(t *testing.T) {
 	// 	buildValueNode := func(v int64) ipld.Node {
 	// 		np := basicnode.Prototype.Map