Merge branch '4.x' into 5.x

Author: danharrin

.github/workflows/manage-issue.yml

@@ -35,8 +35,10 @@ jobs:
             const issue = context.payload.issue
             const body = issue.body
 
-            if (body.includes('filament/minimal-theme')) {
-                debug('Ignoring Minimal Theme issue.')
+            const CORE_TEAM_ASSOCIATIONS = ['OWNER', 'MEMBER', 'COLLABORATOR']
+
+            if (CORE_TEAM_ASSOCIATIONS.includes(issue.author_association)) {
+                debug(`Ignoring issue from core team member with author association '${issue.author_association}'.`)
 
                 return
             }

packages/actions/docs/02-modals.md

@@ -28,6 +28,10 @@ Action::make('delete')
     The confirmation modal is not available when a `url()` is set instead of an `action()`. Instead, you should redirect to the URL within the `action()` closure.
 </Aside>
 
+<Aside variant="info">
+    Confirmation modals use the `alertdialog` ARIA role instead of `dialog`, so screen readers announce them as alerts and automatically read the modal's description when they open.
+</Aside>
+
 ## Controlling modal content
 
 ### Customizing the modal's heading, description, and submit action label

packages/actions/resources/views/action-modal.blade.php

@@ -3,6 +3,7 @@
     use Filament\Support\Facades\FilamentView;
     use Illuminate\Support\Js;
 
+    $actionIsModalAlert = $action->isConfirmationRequired();
     $actionModalAlignment = $action->getModalAlignment();
     $actionIsModalAutofocused = $action->isModalAutofocused();
     $actionIsModalClickThrough = $action->isModalClickThrough();
@@ -33,6 +34,7 @@
 @endphp
 
 <x-filament::modal
+    :alert="$actionIsModalAlert"
     :alignment="$actionModalAlignment"
     :autofocus="$actionIsModalAutofocused"
     :click-through="$actionIsModalClickThrough"

packages/forms/dist/components/code-editor.js

@@ -24,6 +24,7 @@ export default function codeEditorFormComponent({
     isLive,
     isLiveDebounced,
     isLiveOnBlur,
+    label,
     liveDebounce,
     language,
     state,
@@ -49,6 +50,13 @@ export default function codeEditorFormComponent({
                     extensions: [
                         basicSetup,
                         keymap.of([indentWithTab]),
+                        ...(label
+                            ? [
+                                  EditorView.contentAttributes.of({
+                                      'aria-label': label,
+                                  }),
+                              ]
+                            : []),
                         ...(canWrap ? [EditorView.lineWrapping] : []),
                         EditorState.readOnly.of(isDisabled),
                         EditorView.editable.of(!isDisabled),

packages/forms/dist/components/select.js

@@ -10,6 +10,7 @@ export default function selectFormComponent({
     hasDynamicOptions,
     hasDynamicSearchResults,
     hasInitialNoOptionsMessage,
+    id,
     initialOptionLabel,
     initialOptionLabels,
     initialState,
@@ -53,6 +54,7 @@ export default function selectFormComponent({
                 hasDynamicOptions,
                 hasDynamicSearchResults,
                 hasInitialNoOptionsMessage,
+                id,
                 initialOptionLabel,
                 initialOptionLabels,
                 initialState,

packages/forms/dist/components/slider.js

@@ -64,6 +64,19 @@ export default function sliderFormComponent({
                 tooltips,
             })
 
+            if (this.$el.id) {
+                // `noUiSlider` handles are focusable `role="slider"` elements, but it does not
+                // give them an accessible name, so they inherit the field's label element.
+                this.$el
+                    .querySelectorAll('.noUi-handle')
+                    .forEach((handle) =>
+                        handle.setAttribute(
+                            'aria-labelledby',
+                            `${this.$el.id}-label`,
+                        ),
+                    )
+            }
+
             if (isDisabled) {
                 this.slider.disable()
             }

packages/forms/resources/js/components/code-editor.js

@@ -126,6 +126,8 @@
 
         'editor' => [
 
+            'label' => 'Image editor',
+
             'actions' => [
 
                 'cancel' => [