Skip to content

Performance issue on invisible summaries #15919

Open
@bernhardh

Description

@bernhardh

Package

filament/filament

Package Version

v3.3.4

Laravel Version

v12.3.0

Livewire Version

v3.6.2

PHP Version

8.3.19

Problem description

When hiding all summaries of a table, there is still a performance impact on the page which is weird. Plus the summary is still shown (just without the values).

Just for the records: The usecase of hiding summaries (at all) is to use an Action to toggle them. This is usefull on large tables to improve performance or when having multiple summarizers to make the table cleaner for most users.

I think this bug was introduced in PR #15594

Expected behavior

  1. When using ->visible(false) on a summary, the query for the summary shouldn't be used.
  2. When using ->visible(false)on ALL summaries, there should be no summary at all shown.

Steps to reproduce

See repo url and use the issue/table-summary branch. This is just a fork of the filament demo repo. All changes are in the OrderResource class. To keep it simple, I only set the summarizer to hidden, without the Action an toggling logic.

When adding ->visible(false) to both summaries, this is how it looked like in when using Filament (for example) v3.2.123:

Image

After upgrade to v3.3.5 this is how it looks like:

Image

Reproduction repository (issue will be closed if this is not valid)

https://github.com/bernhardh/filamentdemo

Relevant log output

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status

    Todo

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions