Confusingly named `SimultaneousTransfersForStorage` and `SimultaneousTransfersForStoragePerClient` config values

[Reiers]

Checklist

• This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
• This is not a new feature request. If it is, please file a feature request instead.
• This is not an enhancement request. If it is, please file a improvement suggestion instead.
• I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
• I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
• I did not make any code changes to boost.

Boost component

• boost daemon - storage providers
• boost client
• boost UI
• boost data-transfer
• boost index-provider
• Other

Boost Version

boostd version 1.6.0+git.aced70f

Describe the Bug

I've encountered an issue setting "SimultaneousTransfersForStoragePerClient" to a higher value than "SimultaneousTransfersForStorage". Boost downloads 20 at the same time, and do not honor "SimultaneousTransfersForStorage = 5" like it states in the config.toml

[LotusDealmaking]
# env var: LOTUS_LOTUSDEALMAKING_SIMULTANEOUSTRANSFERSFORSTORAGE

SimultaneousTransfersForStorage = 5

 # env var: LOTUS_LOTUSDEALMAKING_SIMULTANEOUSTRANSFERSFORSTORAGEPERCLIENT

SimultaneousTransfersForStoragePerClient = 20

Expected behavior:

Deals from a certain client will queue up while 5 is transferring.

Logging Information

Not needed.

Repo Steps

1. Set "SimultaneousTransfersForStorage" to 5.
2. Set "SimultaneousTransfersForStoragePerClient" to 20.
3. Save the configuration and observe that Boost accepts 20 transfers instead of queue them up, and limit the transfers to 5

[dirkmc]

SimultaneousTransfersForStorage and SimultaneousTransfersForStoragePerClient are actually only relevant to legacy deal transfers.
We should probably rename these config parameters to make them clearer.

For the new (http) transfers, the relevant parameter is HttpTransferMaxConcurrentDownloads

[LexLuthr]

@Reiers We have disabled legacy market by default in Boost v2. Since we are phasing out legacy deals, these options will go away from config soon. Shall we close this out?